Add getting-started-test-pipeline.yml #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying documentation with
|
| Latest commit: |
c506d4d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7fc91b5b.documentation-7tp.pages.dev |
| Branch Preview URL: | https://awg-add-getting-started-test.documentation-7tp.pages.dev |
|
Cloudflare deployment logs are available here |
|
Good to see progress on this. It looks like this is intended to address #892. Want to edit the description to say so? |
dckc
reviewed
May 14, 2024
ghost
mentioned this pull request
ansabgillani
force-pushed
the
awg/add-getting-started-test-pipeline.yml
branch
2 times, most recently
from
90585e8 to
8a22f89
Compare
ansabgillani
changed the title
frazarshad
reviewed
May 15, 2024
dckc
reviewed
May 15, 2024
Comment on lines
29
to
55
| - name: Wait for Docker container to be ready | ||
| # cd demo | ||
| # yarn install | ||
| # yarn start:docker | ||
| # # - name: yarn docker:logs | ||
| # # run: yarn docker:logs | ||
| # yarn build | ||
| # # Borrowed from https://github.com/DCFoundation/cosmos-proposal-builder/blob/main/.github/workflows/pr.yml#L43-L61 | ||
| run: | | ||
| cd demo | ||
| timeout 300 bash -c ' | ||
| TARGET_HEIGHT=1111 | ||
| SLEEP=10 | ||
| echo "Waiting for the Agoric service to be fully ready..." | ||
| echo "Target block height: $TARGET_HEIGHT" | ||
| while true; do | ||
| response=$(curl --silent http://localhost:26657/abci_info); | ||
| height=$(echo $response | jq -r ".result.response.last_block_height | tonumber"); | ||
| if [ "$height" -ge $TARGET_HEIGHT ]; then | ||
| echo "Service is ready! Last block height: $height"; | ||
| break; | ||
| else | ||
| echo "Waiting for last block height to reach $TARGET_HEIGHT. Current height: $height"; | ||
| fi; | ||
| sleep $SLEEP; | ||
| done | ||
| ' |
There was a problem hiding this comment.
consider pushing this wait-for-blocks code down into contract/Makefile or a script in contract/scripts/
see also:
frazarshad
reviewed
May 30, 2024
ansabgillani
force-pushed
the
awg/add-getting-started-test-pipeline.yml
branch
from
3cefc44 to
3e43d0b
Compare
frazarshad
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding getting-started-test-pipeline.yml to the pipeline and ensure it runs as mentioned in the docs.
Will only run on
mainbranch on dapp-offer-upfixes #892