Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add follow command to Agoric CLI Reference #1116

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

ansabgillani
Copy link
Contributor

Add follow command reference to doc

Copy link

cloudflare-workers-and-pages bot commented Jun 3, 2024

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: c616f02
Status: ✅  Deploy successful!
Preview URL: https://73f067b9.documentation-7tp.pages.dev
Branch Preview URL: https://awg-add-follow-command-to-ag.documentation-7tp.pages.dev

View logs

Copy link

github-actions bot commented Jun 3, 2024

Cloudflare deployment logs are available here

Copy link
Contributor

@toliaqat toliaqat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has output of --help, which might not be ideal content for documentation. The reason is that these options can get change over time. In the documentation, we usually add stuff that is long-lasting and might not have explained in the --help option.

@ansabgillani ansabgillani force-pushed the awg/add-follow-command-to-agoric-cli branch from c616f02 to 5efb2fb Compare June 5, 2024 09:14
@ansabgillani
Copy link
Contributor Author

#1116 (review)
Just followed the conventions here from the rest of the page. Based on our conversation, all good.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@Jovonni Jovonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -44,6 +44,45 @@ See also:

- [`agoric run` supports bundling proposal modules with writeCoreProposal](https://github.com/Agoric/agoric-sdk/discussions/8087#discussioncomment-6534378) discussion [#8087](https://github.com/Agoric/agoric-sdk/discussions/8087) 2023-07

## agoric follow

Follow an Agoric Casting leader tosupport vstorage query along with some of the marshalling conventions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tosupport -> to support

@amessbee amessbee merged commit 5fbe1dd into main Jul 26, 2024
5 checks passed
@amessbee amessbee deleted the awg/add-follow-command-to-agoric-cli branch July 26, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants