-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new DMS video format #139
Comments
That video has been deleted, unfortunately. DMS is still going through a gradual rollout and videos/users are being selected randomly. I've been trying a few videos uploaded after 2023-11-01 and haven't found any examples of 1080p failing, so DMC seems predominant even still, and I haven't found any word on when older videos might be transitioned off DMC. The other benefit of this change is that videos 30-60 minutes long can use 720p now (and also 1080p as of 12/15). sm43110779 can still be downloaded, but only in the expected 360p with DMC. This seems likely to not be abandoned like a lot of the Nicocas functionality (#48) so we sould work on this. It seems like a fairly straightforward m3u8 manifest is retrieved and there might be some light encryption (probably doesn't matter, seems like the access key might be given directly in the page params). Current concerns:
|
Getting to the media URLs is pretty trivial and enumerating qualities doesn't take much tweaking. We'll need to settle on a way to mux these to a file, like m3u8-to-MP4, but might just have to do it from scratch to maintain our session. Additionally, that allows us to probably introduce a new flag to specify video or audio only for download. |
Ah, didn't realize we don't have an HLS/m3u8 downloader already. Once we have that in place, it should be very helpful for implementing #11 too (I already wrote a quick one for my own usage (https://github.com/fireattack/python-scripts/blob/master/nico.py) but I use external tools to handle the actual HLS downloading.) |
In my testing it doesn't really seem like the segments will need a session maintained to retrieve everything, however the key will 403 otherwise. So my thinking is we can probably retrieve the key, rewrite the manifest to use a local key file, and just let
Think we'll also need |
All indications at this point seem to be that DMS is available for all videos now. To clarify where things stand with #146 (which I'm going to merge shortly):
|
* Add support for DMS video delivery Continues work on #139 * Reorder generic method * Capture progress and failures, use tqdm, overwrite without prompt * Add -r warning * Fix warning * Check for overwrite, support --break-on-existing * Accept the clumsy paramters check, for now * Use .part for downloads that were interrupted * Reconsider -r support * Use return * Always overwrite .part files, clarify behavior when they exist
Nico started rolling out new "DMS" video/stream format.
Currently some video's certain quality (e.g. 1080p of this video) can only be obtained via DMS, which means NNdownload can only download up to 720p now.
See also:
yt-dlp/yt-dlp#8685
yt-dlp/yt-dlp#8758
The text was updated successfully, but these errors were encountered: