Add support for DMS video delivery #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will resolve #139. Currently we download the manifests and keys, rewrite them to use the local paths to the keys, and then perform the download using
ffmpegas a subprocess. Specifying different qualities is also supported as it was with DMC delivery. Going to get this merged first before we think about adding no audio/video flags for specificying qualities as we'll need to rewrite file extensions. After that we'll think about finally splitting this up by classes because we have a lot of competing mechanisms now.Resuming partial downloads and multithreading are not supported due to
ffmpeglimitations, so #148 has been opened to achieve more robust support. As a result, we now write partial or in progress downloads to.partfiles and update to the correct extension when a download is complete. The full extension will be presumed to be a complete download, so this will report incorrectly for any remanining partial downloads out in the wild (and we should really introduce a flag to force overwrites).