Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-29973 Dynamic component properties #10540

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

tomaszhanaj
Copy link
Contributor

@tomaszhanaj tomaszhanaj commented Jan 9, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?
https://hyland.atlassian.net/browse/AAE-29973

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
#10539
Should be merged first

@tomaszhanaj tomaszhanaj changed the base branch from develop to feature/AAE-29971-buttons January 9, 2025 15:29
Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomaszhanaj can we add some unit test coverage?

@tomaszhanaj tomaszhanaj force-pushed the feature/AAE-29971-buttons branch from bb43776 to f24d047 Compare January 15, 2025 08:59
Base automatically changed from feature/AAE-29971-buttons to develop January 15, 2025 10:20
@tomaszhanaj tomaszhanaj force-pushed the feature/AAE-29973-dynamic-component-properties branch from 97b795d to 556d9d6 Compare January 15, 2025 10:22
@tomaszhanaj tomaszhanaj force-pushed the feature/AAE-29973-dynamic-component-properties branch from 556d9d6 to ad2cec1 Compare January 17, 2025 08:49
@tomaszhanaj tomaszhanaj merged commit 4fb0fdd into develop Jan 17, 2025
19 checks passed
@tomaszhanaj tomaszhanaj deleted the feature/AAE-29973-dynamic-component-properties branch January 17, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants