app_rpt.c: change timers of unnecessary long to int #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changed timers are unnecessarily of type long.
I think your math may be off. A [32-bit] "int" has a max value of 0x7FFFFFFF (2147483647). If that number is in "ms" then we would have 2147483647/1000 = 2147483 seconds (24+ days). As long as we're not computing how much time has elapsed at that scale we should be good. |
Allan-N
approved these changes
Jan 28, 2025
mkmer
added
the
code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how I missed the compiler warnings when I tested #457
The changed timers are unnecessarily
long. We could alternately go withlongfor all timers if there is concern about expanding beyond 32767ms for any timer. Currently all of them appear to fit in anint.