Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HostFilesUpdate change to include local changes #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hickey
Copy link

@hickey hickey commented May 7, 2020

Changed the process for updating the files downloaded from
pistar.uk. Allows the entire file to be overwritten by a file named
<FILE>-override. Otherwise the file will be downloaded from pistar.uk
and will add <FILE>-prepend and <FILE>-append files to the
downloaded file if they exist. The final operation is to allow a hook
script to modify the file with non-trivial changes. The hook script if
found is named <FILE>.sh. All of these files are located in
~pi-star/etc.

Signed-off-by: Gerard Hickey [email protected]

@hickey
Copy link
Author

hickey commented May 7, 2020

One or two more notes to go along with this PR.

  • The location for the host file overrides is set to ~pi-star/etc in the script. I figured this is a much better place than /root that has been used elsewhere in the script due to the fact that not all the users of pi-star have really good Unix skills. So putting the host file overrides in a location that would make it much easier for users (and even novice users) to find/create made much more sense to me.

  • The backup script should probably be updated to also include ~pi-star/etc in the list of files that get backed up and restored.

  • Not sure where your documentation is kept, but there should be a paragraph or two to explain how to override the host files. If the documentation is in a repo, then I would be happy to do an initial pass at writing the documentation.

@hickey
Copy link
Author

hickey commented May 14, 2020

Just a ping to get some feedback and discussion going.

hickey added 3 commits March 10, 2021 09:28
Changed the process for updating the files downloaded from
pistar.uk. Allows the entire file to be overwritten by a file named
"<FILE>-override". Otherwise the file will be downloaded from pistar.uk
and will add "<FILE>-prepend" and "<FILE>-append" files to the
downloaded file if they exist. The final operation is to allow a hook
script to modify the file with non-trivial changes. The hook script if
found is named "<FILE>.sh". All of these files are located in
~pi-star/etc.

Signed-off-by: Gerard Hickey <[email protected]>
@hickey hickey force-pushed the hostfile-update-override branch from bf64505 to 2325692 Compare March 10, 2021 17:29
@hickey
Copy link
Author

hickey commented Mar 10, 2021

@AndyTaylorTweet Just another ping to kick off the discussion about this proposed change.

I have just rebased against the current master to keep the branch fresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant