CAPI 219 onboarding instructions config #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adityasingh-anyline
commented
May 15, 2024
adityasingh-anyline
commented
- (feat): add onboarding instructions to describe how to take better tire picture
- (feat): make sdk configurable for the number of times onboarding instructions are shown
- (chore): add routing mechanism to help navigate within sdk screens
- (chore): explicitly initiate stream with aspect ratio of 4/3
- (fix): stream is zoomed in after user cancels taking picture from native camera
…ream and avoid passing stream in-between functions
…unt element making same router instance accessible throughout the application
refactor code to move components to individual screens
…n video element and listen to change in its dimensions this change is helpful in laying out overlay which depends on the size of video element
because upon opening camera natively, stream resolution is updated
CAPI-217(wip): remove overlay fade in animation CAPI-217(wip): instructions popup is not full screen CAPI-217(feat): add bowser to detect ios and safari condition to show overlay conditionally
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… when users native camera aspect ratio is 9:16
…g and initialise sdk accordingly for number of times onboarding screen is shown
…de/show onboarding instructions based on config from initRouter
…t in sdk initialisation
… instructions based on passed config
…nstructions screen was shown when sdk was initialised
add case for negative number timesShown
…ration and onboarding instructions screen
adityasingh-anyline
force-pushed
the
CAPI-219-onboarding-instructions-config
branch
from
3bf5e8e to
925b386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.