feat: add support for Scroll network #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The published version of ape-scroll has too strict version restriction, so I opened a PR to loosen them. This will temporarily point to my fork for testing/reviewing
Barabazs
changed the title
Barabazs
changed the title
antazoey
reviewed
Jul 3, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR adds support for the Scroll network using Scrollscan as the explorer.
How I did it
I followed the same pattern as the other chains in this package.
How to verify it
Updated test case, but couldn't run it locally yet. Need to see if the CI picks it up...
I have tested it manually to use a verified contract on Scroll and it worked as expected.
TO-DO
The ape-scroll package has a version restriction (<0.7.0) that needs to be loosened. I have created a PR on that repo. In the meantime the setup.py points to my fork of that package.EDIT: new ape-scroll was released and the setup.py now points to the published version.
Checklist