refactor!: a collection of breaking changes [APE-1417] #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
antazoey
changed the title
fubuloubu
previously approved these changes
Sep 26, 2023
antazoey
force-pushed
the
feat/zero-seven-todos
branch
from
0f25566 to
27b0a91
Compare
antazoey
force-pushed
the
feat/zero-seven-todos
branch
from
27b0a91 to
534fa85
Compare
|
|
This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days. |
antazoey
force-pushed
the
feat/zero-seven-todos
branch
from
534fa85 to
ef0e404
Compare
antazoey
changed the title
NotPeopling2day
approved these changes
Dec 10, 2023
| @@ -231,25 +231,20 @@ def print_choices(self): | |||
|
|
|||
| @property | |||
| def _choices_iterator(self) -> Iterator[str]: | |||
| # Yield real accounts. | |||
| for account in _get_accounts(account_type=self._account_type): | |||
| # NOTE: Includes test accounts unless filtered out by key. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixes: APE-1120 (make
compilers_with_missing_extbe a Set instead of a List)Fixes: APE-578 (Move ContractError as base class to TransactionError)
Fixes: APE-770 (Remove ape.utils.Aborts - should now use ape.exceptions.Abort)
Fixes: APE-772 (Renamed get_user_selected_account to select_account)
Fixes: APE-822 (Rename ContractError to ContractDataError and other error usage changes)
Fixes: APE-830 (Remove deprecated field
branchfrom the Github dependency type. Userefnow)Fixes: APE-685 (Remove ListTupleConverter)
Fixes: APE-1205 (Use block_id instead of block_identified and include in official API, same with state).
Fixes: APE-876 (Delete some methods for gas tracking from the ReportManager - plugins should be using the test runner reference now, same as coverage)
Fixes: APE-1104 (rename get_storage_at to get_storage)
Fixes: APE-899 (Move Web3Provider to ape-Ethereum)
Unused
evm_versionsfromcompileconfig was removed. This config never did anything.Addresses any breaking-change TODOs related to 0.7 that I found
How I did it
burn it all
How to verify it
Checklist