docs: document ProviderContextManager [APE-618] #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
antazoey
commented
Oct 30, 2023
| print(provider) | ||
| ``` | ||
|
|
||
| **A note about disconnect**: Providers do not disconnect until the very end of your Python session. |
There was a problem hiding this comment.
note: am not against re-designing this as a breaking change but this is how it works today.
We could probably flip it though, like keep_alive=True to keep certain connections from disconnecting and then we can have users do that in their pytest fixtures.
But this is a breaking change; the network disconnect functionality has been around since we were really focused on ape-starknet so I apologize the conflicting use-cases, but I at least want this documented.
fubuloubu
previously approved these changes
Oct 31, 2023
antazoey
force-pushed
the
docs/networks-ctx
branch
from
bc35c25 to
f90c224
Compare
fubuloubu
approved these changes
Oct 31, 2023
vany365
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
[APE-618] #1297
fixes: #1297
Fixes: APE-618
How I did it
How to verify it
Checklist