Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @testing-library/user-event 14.6.0 → 14.6.1 (patch) #341

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jan 22, 2025

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ @​testing-library/user-event (14.6.0 → 14.6.1) · Repo · Changelog

Release Notes

14.6.1

14.6.1 (2025-01-21)

Bug Fixes

  • correct description for delay option (#1175) (2edf14d)
  • keyboard: add ContextMenu to defaultKeyMap (#1079) (3e471d1)
  • keyboard: add brackets to defaultKeyMap (#1226) (543ecb0)
  • keyboard: walk through radio group per arrow keys (#1049) (bf8111c)
  • pointer: dispatch mouse events if pointerdown is defaultPrevented (#1121) (f681f7b)
  • pointer: set button and buttons properties on PointerEvent (#1219) (6614f72)
  • pointer: use 1 as default value for PointerEvent.width and PointerEvent.height (#1224) (f0468d0)
  • prevent click event loop on form-associated custom element (#1238) (465fc7e)
  • prevent click event on non-focusable control (#1130) (e429094)
  • upload: apply accept filter more leniently (#1064) (a344ad4)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 14 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Summary by Sourcery

Bug Fixes:

  • This update fixes several bugs related to keyboard and pointer events, click events on form-associated custom elements and non-focusable controls, and upload functionality.

Description by Korbit AI

What change is being made?

Update the @testing-library/user-event dependency version from 14.6.0 to 14.6.1 in package.json.

Why are these changes being made?

This patch update of @testing-library/user-event includes bug fixes and performance improvements which enhance the stability and efficiency of user event simulations in our testing suite. Keeping dependencies up-to-date ensures we have the latest advancements and security fixes.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

@depfu depfu bot added the depfu label Jan 22, 2025
Copy link

The files' contents are under analysis for test generation.

Copy link

korbit-ai bot commented Jan 22, 2025

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link

sourcery-ai bot commented Jan 22, 2025

Reviewer's Guide by Sourcery

This pull request updates the @testing-library/user-event dependency from version 14.6.0 to 14.6.1. This is a patch update that includes several bug fixes related to keyboard, pointer, and upload events, as well as a fix for a click event loop on form-associated custom elements.

Sequence diagram for updated pointer event behavior

sequenceDiagram
    participant User
    participant Component
    participant PointerEvent
    participant MouseEvent

    Note over Component, PointerEvent: Changes in 14.6.1
    User->>Component: pointerdown (prevented)
    Component->>PointerEvent: dispatch pointerdown
    Note right of PointerEvent: Now includes correct button/buttons properties
    Note right of PointerEvent: Default width/height set to 1
    PointerEvent->>MouseEvent: dispatch mousedown
    Note right of MouseEvent: Now dispatches even when pointerdown prevented
Loading

State diagram for click event handling changes

stateDiagram-v2
    [*] --> ClickAttempt
    ClickAttempt --> PreventClick: Non-focusable control
    ClickAttempt --> ProcessClick: Focusable control
    ProcessClick --> FormAssociated: Is form-associated
    ProcessClick --> StandardClick: Standard element
    FormAssociated --> PreventLoop: Prevent click event loop
    StandardClick --> [*]
    PreventLoop --> [*]
    PreventClick --> [*]
Loading

File-Level Changes

Change Details Files
Updated the @testing-library/user-event dependency to version 14.6.1.
  • Updated @testing-library/user-event from 14.6.0 to 14.6.1 in package.json.
  • Updated @testing-library/user-event from 14.6.0 to 14.6.1 in package-lock.json.
package.json
package-lock.json
Fixed several bugs related to keyboard events.
  • Added ContextMenu to defaultKeyMap.
  • Added brackets to defaultKeyMap.
  • Fixed radio group navigation with arrow keys.
CHANGELOG.md
Fixed several bugs related to pointer events.
  • Dispatched mouse events if pointerdown is defaultPrevented.
  • Set button and buttons properties on PointerEvent.
  • Set default values for PointerEvent.width and PointerEvent.height to 1.
CHANGELOG.md
Fixed a bug related to click events.
  • Prevented click event loop on form-associated custom element.
  • Prevented click event on non-focusable control.
CHANGELOG.md
Fixed a bug related to upload events.
  • Applied accept filter more leniently.
CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Jan 22, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, depfu[bot]!). We assume it knows what it's doing!

@guibranco guibranco enabled auto-merge (squash) January 22, 2025 19:41
@gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Jan 22, 2025
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2025
Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Automated processes or integrations label Jan 22, 2025
@guibranco
Copy link
Member

@depfu merge

Copy link

Infisical secrets check: ✅ No secrets leaked!

💻 Scan logs
7:41PM INF scanning for exposed secrets...
7:41PM INF 455 commits scanned.
7:41PM INF scan completed in 1.2s
7:41PM INF no leaks found

@guibranco guibranco merged commit 9c3b40d into main Jan 22, 2025
18 of 19 checks passed
@guibranco guibranco deleted the depfu/update/npm/@testing-library/user-event-14.6.1 branch January 22, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) 🤖 bot Automated processes or integrations depfu size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant