[DRAFT] Generate scripts programmatically using Nix #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is not yet ready but I'm opening it as a draft to make it visible to upstream. Currently we can generate all pure scripts directly using Nix (here pure refers to not relying on any transient machine state). Prominently, the
build.shscript andsource.shscripts are not pure so we cannot generate those directly.The current plan is to write a pure configure script (e.g.
arcturus-configure) that copies these scripts into the correct location when ran. This script could be ran manually, or as a devshell enterHook. This way we can still avoid configuration drifts between the shell scripts and Nix while allowing impure build scripts to be generated. The end goal of course is to make all scripts pure, so this is a stopgap solution.