Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize call instruction in the VM #497

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Optimize call instruction in the VM #497

merged 2 commits into from
Oct 5, 2024

Conversation

SuperFola
Copy link
Member

Description

Optimize the call instruction in the VM to avoid default constructing n non-POD values for CProcs, just to replace them by another value right after.

Checklist

  • I have read the Contributor guide
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation if needed
  • I have added tests that prove my fix/feature is working
  • New and existing tests pass locally with my changes

…when calling a C++ function

We used to resize our vector, default allocating n values, creating n values, then replacing those
values by ones coming from the stack (copying). This wasn't efficient, we now reserve and copy from
the stack to the vector once, after a call to reserve.
Copy link

github-actions bot commented Oct 5, 2024

Static analysis report

Lizard report

Listing only functions with cyclomatic complexity >= 15 or NLOC >= 100 or parameters >= 6.

Filename Start line:end line Function name Parameters NLOC CCN
src/arkreactor/VM/VM.cpp 266:1142 Ark::VM::safeRun 3 719 159
Report about files you didn't modify in this PR
Filename Start line:end line Function name Parameters NLOC CCN
src/arkreactor/Compiler/BytecodeReader.cpp 196:512 Ark::BytecodeReader::display 4 283 123
src/arkreactor/Compiler/Macros/Processor.cpp 266:574 Ark::internal::MacroProcessor::evaluate 3 291 118
src/arkreactor/Compiler/Compiler.cpp 562:727 Ark::Compiler::handleCalls 5 133 40
src/arkscript/REPL/Repl.cpp 17:229 Ark::Repl::Repl 1 180 35
include/Ark/Compiler/AST/Parser.hpp 105:194 Ark::internal::ARK_APIParser::string 0 87 32
src/arkscript/main.cpp 17:327 main 2 268 30
src/arkscript/JsonCompiler.cpp 26:206 JsonCompiler::_compile 1 151 27
src/arkreactor/Compiler/Compiler.cpp 267:358 Ark::Compiler::compileExpression 5 75 25
src/arkreactor/Compiler/NameResolutionPass.cpp 172:271 Ark::internal::NameResolutionPass::visitKeyword 2 90 25
src/arkreactor/Compiler/AST/Node.cpp 201:271 Ark::internal::Node::debugPrint 1 61 23
include/utf8.hpp 138:184 utf8::isValid 1 44 21
src/arkreactor/Compiler/AST/Parser.cpp 266:393 Ark::internal::Parser::import_ 0 103 21
src/arkreactor/Compiler/Macros/Processor.cpp 117:187 Ark::internal::MacroProcessor::processNode 2 54 21
src/arkreactor/Compiler/Macros/Executors/Function.cpp 12:86 Ark::internal::FunctionExecutor::applyMacro 2 60 18
src/arkreactor/Compiler/NameResolutionPass.cpp 108:170 Ark::internal::NameResolutionPass::visit 1 53 18
src/arkreactor/Compiler/AST/Node.cpp 135:199 Ark::internal::Node::repr 0 56 17
src/arkreactor/VM/Value.cpp 67:125 Ark::Value::toString 1 46 17
include/Ark/Compiler/AST/Predicates.hpp 162:186 Ark::internal::IsSymbol::operator ( ) 1 24 16
src/arkreactor/Compiler/Macros/Processor.cpp 46:91 Ark::internal::MacroProcessor::registerMacro 1 41 16
src/arkreactor/TypeChecker.cpp 28:85 Ark::types::displayContract 2 51 15
src/arkreactor/Exceptions.cpp 86:130 Ark::Diagnostics::makeContext 6 35 15
src/arkscript/Formatter.cpp 161:214 Formatter::format 3 51 15
src/arkreactor/Exceptions.cpp 133:142 Ark::Diagnostics::helper 9 9 3
include/Ark/Exceptions.hpp 92:101 Ark::CodeError::CodeError 6 10 1

CppCheck report

Filename Line Type Description
src/arkreactor/VM/VM.cpp 359 style Statements following return, break, continue, goto or throw will never be executed.
src/arkreactor/VM/VM.cpp 298 error syntax error
Report files about files you didn't modify in this PR
Filename Line Type Description
src/arkreactor/Builtins/IO.cpp 24 style Parameter 'n' can be declared with const
src/arkreactor/Builtins/IO.cpp 43 style Parameter 'n' can be declared with const
include/Ark/Compiler/AST/Optimizer.hpp 64 style Unused private function: 'Optimizer::throwOptimizerError'
include/Ark/Compiler/AST/Optimizer.hpp 70 style Unused private function: 'Optimizer::removeUnused'
src/arkreactor/Compiler/AST/Parser.cpp 385 error Uninitialized variable: import_data.with_prefix
src/arkreactor/Compiler/BytecodeReader.cpp 331 style struct member 'Arg::arg' is never used.
include/Ark/Compiler/Macros/Processor.hpp 170 performance Function parameter 'origin' should be passed by const reference.
src/arkreactor/Compiler/Macros/Executor.cpp 12 performance Function parameter 'origin' should be passed by const reference.
include/Ark/Compiler/Macros/Executor.hpp 71 performance Function parameter 'origin' should be passed by const reference.
src/arkreactor/Compiler/Macros/Executors/Function.cpp 14 style The scope of the variable 'first' can be reduced.
src/arkreactor/Compiler/Macros/Processor.cpp 245 performance Function parameter 'origin' should be passed by const reference.
src/arkreactor/VM/Scope.cpp 51 style Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp 61 style Variable 'id' is not assigned a value.
src/arkreactor/VM/Scope.cpp 71 style Variable 'id' is not assigned a value.
src/arkscript/JsonCompiler.cpp 156 style Consider using std::accumulate algorithm instead of a raw loop.
src/arkscript/JsonCompiler.cpp 163 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 24 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 26 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 28 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 30 style Consider using std::copy algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 36 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 38 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/REPL/Repl.cpp 47 style Consider using std::transform algorithm instead of a raw loop.
src/arkscript/main.cpp 76 information Unmatched suppression: constStatement

@coveralls
Copy link

Coverage Status

coverage: 75.225% (+0.007%) from 75.218%
when pulling f3c50e7 on opti/vm_call
into ee54f06 on dev.

Copy link

github-actions bot commented Oct 5, 2024

Fuzzing report

/usr/local/bin/afl-whatsup status check tool for afl-fuzz by Michal Zalewski

Summary stats

    Fuzzers alive : 0
   Dead or remote : 1 (included in stats)
   Total run time : 5 minutes, 0 seconds
      Total execs : 39 thousands
 Cumulative speed : 130 execs/sec
    Pending items : 93 faves, 812 total
 Coverage reached : 9.71%
    Crashes saved : 0
      Hangs saved : 0

Cycles without finds : 0
Time without finds : 0

[+] Captured 31890 tuples (map size 178397, highest value 255, total values 266180541) in '/dev/null'.
[+] A coverage of 31890 edges were achieved out of 178432 existing (17.87%) with 820 input files.

@SuperFola SuperFola marked this pull request as ready for review October 5, 2024 19:36
@SuperFola SuperFola merged commit 973eba8 into dev Oct 5, 2024
26 checks passed
@SuperFola SuperFola deleted the opti/vm_call branch October 5, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants