Add ability to define environment .htaccess rules #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative would be to add a hook (for example 'aiowps_htaccess_rules') which would allow developers to inject their own .htaccess rules. |
|
I would be more comfortable with a hook like you mentioned. |
This reverts commit e01f311.
v4.4.7 released
|
I created new PR for this: #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables site developer to define environment .htaccess rules in .htaccess.env file which would be copied to .htaccess whenever user/admin updates security settings and aiowps updates .htaccess content.
It could be used in two scenarios:
1.) .htaccess.env is versioned and developer wants it the same for every environment (for example to setup redirects from old url to new without need to copy oiowps configuration (custom rules) to every environment)
2.) .htaccess.env is not versioned (for example to setup different rules for different environments as part of automatic deployment process)
If this PR makes sense for you the idea can be extended further. For example we could add support for combination of two aforementioned scenarios: One file (.htaccess.all) for first scenario and another file (.htaccess.env) for second scenario.