Non-Model Serializer #115
Open
Non-Model Serializer #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that was not inherited from `ModelSerializer`, it appears to have worked correctly for my other case. I will try to add test cases, but wanted to at least get it out there in case someone else has the need.
webjunkie
suggested changes
Feb 27, 2020
drf_hal_json/serializers.py
Outdated
| @@ -7,6 +7,7 @@ | |||
| from rest_framework.serializers import BaseSerializer, HyperlinkedModelSerializer, ListSerializer | |||
| from rest_framework.utils.field_mapping import get_nested_relation_kwargs | |||
| from rest_framework.utils.serializer_helpers import ReturnDict | |||
| from rest_framework.serializers import Serializer | |||
There was a problem hiding this comment.
Please move this to the existing serializers imports.
Class inherits so it's not a Mixin. Co-Authored-By: Julian Bez <[email protected]>
houndci-bot
reviewed
Feb 27, 2020
|
|
||
|
|
||
| class HalModelSerializer(HalSerializerMixin, HyperlinkedModelSerializer): | ||
| """ |
There was a problem hiding this comment.
undefined name 'HalSerializerMixin'
drf_hal_json/serializers.py
Outdated
| @@ -56,7 +52,7 @@ class Meta: | |||
| list_serializer_class = getattr(meta, 'list_serializer_class', None) | |||
| if list_serializer_class is None: | |||
| setattr(meta, 'list_serializer_class', cls.default_list_serializer) | |||
| return super(HalModelSerializer, cls).many_init(*args, **kwargs) | |||
| return super(HalSerializerMixin, cls).many_init(*args, **kwargs) | |||
There was a problem hiding this comment.
Do not call setattr with a constant attribute value, it is not any safer than normal property access.
houndci-bot
reviewed
Feb 27, 2020
drf_hal_json/serializers.py
Outdated
| @@ -143,3 +141,11 @@ class Meta: | |||
| field_kwargs = get_nested_relation_kwargs(relation_info) | |||
|
|
|||
| return field_class, field_kwargs | |||
|
|
|||
|
|
|||
| class HalModelSerializer(HalSerializerMixin, HyperlinkedModelSerializer): | |||
There was a problem hiding this comment.
undefined name 'HalSerializerMixin'
drf_hal_json/serializers.py
Outdated
| @@ -133,7 +131,7 @@ def build_nested_field(self, field_name, relation_info, nested_depth): | |||
| """ | |||
| Create nested fields for forward and reverse relationships. | |||
| """ | |||
| class NestedSerializer(HalModelSerializer): | |||
| class NestedSerializer(HalSerializerMixin): | |||
There was a problem hiding this comment.
undefined name 'HalSerializerMixin'
drf_hal_json/serializers.py
Outdated
| @@ -99,7 +97,7 @@ def to_representation(self, instance): | |||
| return resp | |||
|
|
|||
| def get_fields(self): | |||
| fields = super(HalModelSerializer, self).get_fields() | |||
| fields = super(HalSerializerMixin, self).get_fields() | |||
There was a problem hiding this comment.
undefined name 'HalSerializerMixin'
drf_hal_json/serializers.py
Outdated
| @@ -72,7 +68,7 @@ def _get_url(self, item): | |||
| return None | |||
|
|
|||
| def to_representation(self, instance): | |||
| ret = super(HalModelSerializer, self).to_representation(instance) | |||
| ret = super(HalSerializerMixin, self).to_representation(instance) | |||
There was a problem hiding this comment.
undefined name 'HalSerializerMixin'
drf_hal_json/serializers.py
Outdated
| @@ -56,7 +52,7 @@ class Meta: | |||
| list_serializer_class = getattr(meta, 'list_serializer_class', None) | |||
| if list_serializer_class is None: | |||
| setattr(meta, 'list_serializer_class', cls.default_list_serializer) | |||
| return super(HalModelSerializer, cls).many_init(*args, **kwargs) | |||
| return super(HalSerializerMixin, cls).many_init(*args, **kwargs) | |||
There was a problem hiding this comment.
undefined name 'HalSerializerMixin'
drf_hal_json/serializers.py
Outdated
| default_list_serializer = HalListSerializer | ||
|
|
||
| def __init__(self, instance=None, data=empty, **kwargs): | ||
| super(HalModelSerializer, self).__init__(instance, data, **kwargs) | ||
| super(HalSerializerMixin, self).__init__(instance, data, **kwargs) |
There was a problem hiding this comment.
undefined name 'HalSerializerMixin'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I separated the methods of the
HalModelSerializerinto a class that was not inherited fromModelSerializer, it appears to work correctly for my case (i.e. #112).