finetune assertion and test

Astrotomic · Jul 24, 2021 · 5cc0db7 · 5cc0db7
1 parent c3e9fa3
commit 5cc0db7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/EmailAssertions.php b/src/EmailAssertions.php
@@ -46,7 +46,7 @@ public static function assertPlusAlias(string $expected, $actual): void
     {
         PHPUnit::assertIsString($actual);
         [$localPart] = explode('@', $actual, 2);
-        [$mailbox, $alias] = explode('+', $localPart, 2);
+        [, $alias] = explode('+', $localPart, 2);
         PHPUnit::assertSame($expected, $alias);
     }
 }
diff --git a/tests/EmailAssertionsTest.php b/tests/EmailAssertionsTest.php
@@ -51,7 +51,7 @@ public static function it_can_validate_local_part(): void
     public static function it_can_validate_plus_mailbox(): void
     {
         $mailbox = self::randomString();
-        $alias = self::randomBool();
+        $alias = self::randomString();
         $email = $mailbox.'+'.$alias.'@email.com';
 
         EmailAssertions::assertPlusMailbox($mailbox, $email);
@@ -64,7 +64,7 @@ public static function it_can_validate_plus_mailbox(): void
     public static function it_can_validate_plus_alias(): void
     {
         $mailbox = self::randomString();
-        $alias = self::randomBool();
+        $alias = self::randomString();
         $email = $mailbox.'+'.$alias.'@email.com';
 
         EmailAssertions::assertPlusAlias($alias, $email);