Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull_request_template.md #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

OfryL
Copy link
Contributor

@OfryL OfryL commented Oct 4, 2023

ℹ️ PR description:

updating pr template to our new flow

📋 PR tasks:

Footnotes

  1. Deploy By Risk Level – FigJam

@OfryL OfryL requested a review from a team as a code owner October 4, 2023 12:07
@OfryL OfryL requested review from atlowChemi and removed request for a team October 4, 2023 12:07
@atlowChemi
Copy link
Member

@OfryL @dorshay6 I think using Github labels would be easier:
It would allow selecting one without the need of editing the description, it would be more visible (no need to enter PR in order to see it) and we could search PRs based on it much easier...

@OfryL
Copy link
Contributor Author

OfryL commented Oct 4, 2023

@OfryL @dorshay6 I think using Github labels would be easier: It would allow selecting one without the need of editing the description, it would be more visible (no need to enter PR in order to see it) and we could search PRs based on it much easier...

Relevant labels were added in org level, this will effect new repos only.

@atlowChemi
Copy link
Member

Relevant labels were added in org level, this will effect new repos only.

@OfryL I think we should prefer labels due to their advantages, and add them as we go... (anyone opening a PR in a repo which doesn't have the labels yet should add them to that repo)

@ofek-autofleet
Copy link

@atlowChemi how would these labels work?
@OfryL i think the risk assesment should stay in the jira, to be our source of truth (these might change and we don't want to change it in 2 places)
i also think the meaningful descriptions should be elaborate
also add a unit test square and todo section (maybe stuff left until finished)

@atlowChemi
Copy link
Member

@atlowChemi how would these labels work?

Not sure what you mean by "work".
An individual opening a PR would mark the PR with the relevant label based on his assumption.
This would allow the reviewers to be more alert when reviewing yellow/red PRs, and it would allow having a documented discussion if someone disagrees with the risk assessment...

@OfryL i think the risk assesment should stay in the jira, to be our source of truth (these might change and we don't want to change it in 2 places)

We could add a GHA that updates Jira by API when a PR label is changed...

@Autofleet Autofleet locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants