Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/unowned section to list #41312

Merged
merged 19 commits into from
Feb 7, 2025
Merged

Update/unowned section to list #41312

merged 19 commits into from
Feb 7, 2025

Conversation

CodeyGuyDylan
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan commented Jan 24, 2025 •
edited
Loading

Proposed changes:

  • Change the unowned section of My Jetpack to a DataViews list
  • This PR will not include the filter, that will be handled in a follow-up PR

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

P2: pghfsA-2S-p2

Does this pull request change what data or activity we track or use?

Yes, we are adding a new usage of the Action Button with a unique identifier for the tracks used in the DataView. The same types of actions are being tracked, but with different event names

Testing instructions:

  1. Checkout this branch via the Jetpack Beta plugin or your local dev environment
  2. Go to My Jetpack and ensure you see a list of products instead of a product grid for un-owned products
    image
  3. Using the search bar, try searching by category (i.e. "performance", "growth", etc.) and ensure the search works correctly. Also try searching by title or description
    image
    image
    image
  4. Click all the CTA's and ensure they go to the correct place (most are "Learn More", they should go to the product interstitials)
    NOTE: Social says Activate when it needs user connection. This is an existing issue and I have added a maintenance item to handle this separately
  5. Try connecting your site and user account and make sure the list is updated accordingly
    image
  6. Try "Activating" social from the list, ensure that it works correctly
    image

Feel free to try any other CTA actions that show up, from my testing I think the only ones that show up are Learn More and Activate. Hopefully after the maintenance task to fix Social, it only ever shows "Learn More" but I don't think anything is broken despite that

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/unowned-section-to-list branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/unowned-section-to-list

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/unowned-section-to-list

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Package] My Jetpack [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Status] In Progress labels Jan 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Backup plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 24, 2025
@CodeyGuyDylan CodeyGuyDylan force-pushed the update/unowned-section-to-list branch from 8454715 to 37eaa07 Compare January 30, 2025 15:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/my-jetpack/src/products/class-stats.php 49/81 (60.49%) 0.24% 1 💔
projects/packages/my-jetpack/src/products/class-product.php 170/272 (62.50%) 0.14% 0 💚

13 files are newly checked for coverage. Only the first 5 are listed here.

File Coverage
projects/packages/my-jetpack/_inc/components/products-table-view/constants.ts 0/5 (0.00%) 💔
projects/packages/my-jetpack/_inc/components/products-table-view/icons/anti-spam.tsx 0/2 (0.00%) 💔
projects/packages/my-jetpack/_inc/components/products-table-view/icons/backup.tsx 0/2 (0.00%) 💔
projects/packages/my-jetpack/_inc/components/products-table-view/icons/boost.tsx 0/2 (0.00%) 💔
projects/packages/my-jetpack/_inc/components/products-table-view/icons/crm.tsx 0/2 (0.00%) 💔

Full summary · PHP report · JS report

@CodeyGuyDylan CodeyGuyDylan marked this pull request as ready for review January 30, 2025 19:51
@CodeyGuyDylan CodeyGuyDylan force-pushed the update/unowned-section-to-list branch from 77fcbbc to 0180d00 Compare January 30, 2025 21:41
IanRamosC
IanRamosC previously approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and could see that it works really well, just left a few minor comments. Feel free to merge after you address them if necessary.

projects/packages/my-jetpack/_inc/components/products-table-view/index.tsx
import SearchIcon from './icons/search';
import SocialIcon from './icons/social';
import StatsIcon from './icons/stats';
import VideopressIcon from './icons/videopress';
Copy link
Contributor

@IanRamosC IanRamosC Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smallest nitpick in the world: for some reason, the lowercase P in Videopress everywhere it's being used is throwing me off 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I personally prefer it this way due to the snake case being videopress_icon, so I'll probably leave it 😅

projects/packages/my-jetpack/_inc/components/products-table-view/style.scss Outdated
@import '@wordpress/components/build-style/style.css';

:root {
--font-size: 13px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually use 16 as the base font-size and, comparing the mockups with the actual implementation, it looks smaller than in the mockups. Checking the values there, it also seems different. Did that change somewhere?

Copy link
Contributor Author

@CodeyGuyDylan CodeyGuyDylan Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'm not actually sure where this came from anymore, I'll remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually only updating the font size of the CTAs, the font sizes of the table itself come from the dataviews component.

projects/packages/my-jetpack/_inc/components/products-table-view/style.scss Outdated
}

button.components-button.is-secondary {
padding: calc( var(--spacing-base) / 2 ) var(--spacing-base) !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to get rid of important with more specificity? I know it's not always possible with how we've been using CSS Modules, but it helps to have a more predictable code and behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this was required before 🤔

Seems to be working without it now, thanks!

@CodeyGuyDylan CodeyGuyDylan force-pushed the update/unowned-section-to-list branch from 2fe5693 to 243e94b Compare February 6, 2025 21:31
IanRamosC
IanRamosC approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling changes look good.

@CodeyGuyDylan CodeyGuyDylan merged commit 263930e into trunk Feb 7, 2025
80 checks passed
@CodeyGuyDylan CodeyGuyDylan deleted the update/unowned-section-to-list branch February 7, 2025 16:20
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] In Progress labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanRamosC IanRamosC IanRamosC approved these changes

Assignees
No one assigned
Labels
[Package] My Jetpack [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Tests] Includes Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodeyGuyDylan @IanRamosC @elliottprogrammer