-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Protection: Add custom password strength meter #41485
base: add/packages/account-protection-password-validation
Are you sure you want to change the base?
Account Protection: Add custom password strength meter #41485
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
projects/packages/account-protection/src/js/jetpack-password-strength-meter.js
Dismissed
Show dismissed
Hide dismissed
…to add/packages/account-protection-password-strength-meter
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
…to add/packages/account-protection-password-strength-meter
…to add/packages/account-protection-password-strength-meter
…to add/packages/account-protection-password-strength-meter
…to add/packages/account-protection-password-strength-meter
…to add/packages/account-protection-password-strength-meter
Description
Replaces the core password strength meter UI—found in password management UIs (add new user, update profile, and password reset forms)—with a branded Jetpack strength meter that applies a custom set of password validation rules. We can enqueue our own JS to run on top of the core validation (using its set as an additional check) and our set to further harden to validation process without needing change the form submission flow or any major core functionality.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
/wp-admin/user-new.php
/wp-admin/user-edit.php?user_id=<user_id>
/wp-admin/profile.php
/wp-login.php?action=lostpassword
Screenshots
profile.php
(user-specific):new-user.php
(non user-specific):edit-user.php
(non user-specific):action=rp || action=resetpass
(non user-specific):