Blogger Launchpad - add add_first_subscribers and verify_email tasks.

[Addison-Stavlo]

Fixes # Automattic/loop#252

related to Automattic/wp-calypso#99207

Proposed changes:

• Adds a add_first_subscribers launchpad task definition.
  • This task is intended to be marked complete when engaged with on the front-end, and not to depend on whether or not subscribers were actually added (noted in Automattic/loop#253). Because of this, we don't want to use or map to the subscribers_added task which requires adding subscribers for completion, but we check other subscribers tasks in the completion callback for this new task. (e.g. subscribers_added completion implies add_first_subscribers completion, but not the other way around).
• Adds the add_first_subscribers task and the verify_email task to the write intent launchpad task list.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Patch this branch to your sandbox: bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/subscribers-task-to-blogger-launchpad (taken from instructions below)
• Sandbox the public-api.
• Test alongside instructions in Launchpad - add handling for new add_first_subscribers task. wp-calypso#99207

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/subscribers-task-to-blogger-launchpad branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/subscribers-task-to-blogger-launchpad
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/launchpad/launchpad-task-definitions.php	662/1514 (43.73%)	0.15%	5 💔
projects/packages/jetpack-mu-wpcom/src/features/launchpad/launchpad.php	75/582 (12.89%)	-0.04%	2 💔

Full summary · PHP report · JS report

[artemiomorales]

Tests well and the code changes looks reasonable to me 👍

[Addison-Stavlo]

Since the last review I have:

• Added wpcom_launchpad_is_add_first_subscribers_completed callback to the new task
• Added the verify_email task to the write flow

[DustyReagan]

I tested this along with the Calypso PR, and it's working as expected. The comments are helpful as well.