Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions: allow pre-selecting newsletter categories in block settings #41567

Open
wants to merge 16 commits into
base: trunk
Choose a base branch
from

Conversation

holdercp
Copy link
Contributor

@holdercp holdercp commented Feb 5, 2025

Closes Automattic/loop#378

New to block development and Jetpack so please review with a critical eye.

Proposed changes:

  • Adds new options in the Subscriptions block settings that will allow site owners to select newsletter categories that this subscription form will automatically subscribe users to
  • These selected categories will be exposed to the subscription form so the category selection modal can be bypassed when this new option is enabled
image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • pe7F0s-2tV-p2 (current project)
  • pe7F0s-2t7-p2 (abandoned project but has some of the discussion around this change)

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Follow documentation to checkout this branch on your sandbox
  • Enable Newsletter Categories for your site and add a few
  • Add a Subscribe block to a post
  • In the Subscribe settings sidebar, under Settings, verify the new "Pre-select Categories" toggle works as expected
    • If enabled, you should be able to selected specific categories for the block
    • If disabled, you should not be able selected specific categories (they should clear if some were selected)
    • Make sure when you save the block and visit it again the settings persist
  • These block settings have no effect currently but you can verify the correct category ids are being selected by examining the markup from the block. There will be a hidden input with the selected ids named selected_newsletter_categories

@holdercp holdercp self-assigned this Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/newsletter-cats-to-sub-block branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/newsletter-cats-to-sub-block
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Subscriptions [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 5, 2025
@holdercp holdercp added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Code Coverage Summary

Coverage changed in 5 files.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/blocks/subscriptions/subscriptions.php 10/622 (1.61%) -0.01% 4 💔
projects/plugins/jetpack/extensions/blocks/subscriptions/controls.js 16/21 (76.19%) 1.19% 1 💔
projects/plugins/jetpack/extensions/blocks/subscriptions/view.js 0/43 (0.00%) 0.00% 1 💔
projects/plugins/jetpack/extensions/blocks/subscriptions/edit.js 45/54 (83.33%) 0.98% 0 💚
projects/plugins/jetpack/extensions/store/membership-products/resolvers.js 65/106 (61.32%) 8.49% -9 💚

Full summary · PHP report · JS report

@holdercp holdercp removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 5, 2025
@holdercp
Copy link
Contributor Author

holdercp commented Feb 6, 2025

This will need to be released after backend changes are in place. Leaving as draft for now but I would love a review to catch any obvious issues that will need to be addressed.

@holdercp holdercp force-pushed the add/newsletter-cats-to-sub-block branch from b4c974d to 97ca4c2 Compare February 7, 2025 22:55
@holdercp holdercp marked this pull request as ready for review February 7, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Team Review [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant