Boost: Run the 404 tester when concatenate modules are enabled

[donnchawp]

Make sure to run the 404 tester each time either of the concatenate modules is enabled. This lets the plugin react more quickly to changes in wp-content/ in case mod_rewrite support has changed.

Fixes #

Proposed changes:

• Added Activate trait to concatenate classes

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pc9hqz-3kc-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

• Apply the PR
• Add an error_log to the activate functions added to confirm they're called.
• Toggle both concatenate modules off and on again.
• Run tests with composer phpunit from projects/plugins/boost/

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Boost plugin:

• Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[dilirity]

We had this previously and we removed it. We're just adding it back in.

[github-actions]

Code Coverage Summary

No summary data is avilable for parent commit 7c65315, cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, you might try re-running the Tests / Publish coverage data job on this PR once the corresponding job on the trunk commit has succeeded.

Full summary · PHP report · JS report

[LiamSarsfield]

LGTM. Thanks for adding back in the tester upon activation. Unit tests also pass locally for me 👍
Do/should we clear the scheduled cron/event if the user deactivates both the JS and CSS minify?

[dilirity]

Nice work on this! Thanks for adding the tests.

Not sure if you knew this, but you can run tests from an individual file using this command:

composer phpunit --filter tests/php/lib/minify/test-functions-service.php

This will save you time while working on them in the future.

EDIT:

Do/should we clear the scheduled cron/event if the user deactivates both the JS and CSS minify?

@LiamSarsfield Yes we should. Good catch!