Add/transient to cache backup api calls

[CodeyGuyDylan]

Proposed changes:

Currently we are making 2 API calls to WPCOM for the backup card (if a backup plan is active) on every page load

• Cache Backup API calls in My Jetpack to avoid calling them on every page load
• Cache for 5 minutes if there was an error with their last backup, that way they can check to see if it was fixed if they try troubleshooting it
• Cache for 1 hour if the previous backup was successful so that, if there is a backup with an error, they'll know about it within an hour if they go to My Jetpack

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

1. Checkout this branch via the Jetpack Beta plugin or your local dev environment (local environment is preferred here so you can delete the transient if you need to)
2. If you go to My Jetpack before the backup has errors, you'll have to delete the transient. You can do this by putting the following line of code above this line

delete_transient( self::BACKUP_STATUS_TRANSIENT_KEY );

3. Connect your site and user account
4. Purchase a VaultPress Backup plan for your site
5. Go to /wp-admin/admin.php?page=jetpack-backup and trigger a backup
6. Right after doing that, disconnect your site so that the backup will fail
7. Go to My Jetpack and ensure you see the error
   
8. Open up the query monitor and see that a request to /rewind and /rewind/backup were made
   
9. Refresh the page, and ensure those requests were not made again (as long as you didn't wait 5 minutes to refresh)
10. If you'd like, you can re-trigger the backup to ensure it was successful, wait 5 minutes from the last time you went to My Jetpack and ensure the request is made again, and the error is gone
    

If you'd like to check the transient values, you can run this locally and add the following line to projects/packages/my-jetpack/src/products/class-backup.php line 249

l( $previous_backup_status );

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/transient-to-cache-backup-api-calls branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack add/transient-to-cache-backup-api-calls
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Code Coverage Summary

No summary data is avilable for parent commit 4f69df2, cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, you might try re-running the Tests / Publish coverage data job on this PR once the corresponding job on the trunk commit has succeeded.

Full summary · PHP report · JS report

[elliottprogrammer]

• Cache for 5 minutes if there was an error with their last backup, that way they can check to see if it was fixed if they try troubleshooting it
• Cache for 1 hour if the previous backup was successful so that, if there is a backup with an error, they'll know about it within an hour if they go to My Jetpack

Ok yes, this ⬆️ seems reasonable. 👍

Tested, works as described. Looks all good, except for an unused and unnecessary variable constant that was left in class-initializer.php that should be removed.
LGTM! 👍

[elliottprogrammer]

This constant is unused in this file. Was it left here in this file unintentionally?
I believe it should be removed. 😉

[CodeyGuyDylan]

Ooh nice catch, thanks I'll remove that!