Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add support for "don't care about coverage" label #41613

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Feb 6, 2025

Proposed changes:

One feature we want for the code coverage check is the ability to easily (but intentionally) override the check for PRs where getting things done is more important than code coverage.

We've decided to do this by allowing for a label, currently named "I don't care about code coverage for this PR", to be added to the PR to override the check.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Add and remove the label on this PR, see how things work out.

One feature we want for the code coverage check is the ability to easily
(but intentionally) override the check for PRs where getting things done
is more important than code coverage.

We've decided to do this by allowing for a label, currently named
"I don't care about code coverage for this PR", to be added to the PR to
override the check.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal labels Feb 6, 2025
@anomiex anomiex requested a review from a team February 6, 2025 20:10
@anomiex anomiex self-assigned this Feb 6, 2025
@anomiex anomiex added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Feb 6, 2025
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@anomiex anomiex removed the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Feb 6, 2025
@anomiex anomiex added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Feb 6, 2025
@anomiex anomiex removed the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label Feb 6, 2025
@anomiex anomiex added I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. and removed I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@anomiex anomiex added I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Status] In Progress labels Feb 6, 2025
@anomiex anomiex added I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. Unit Tests and removed I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Feb 7, 2025
@anomiex anomiex removed the Unit Tests label Feb 7, 2025
@tbradsha tbradsha added I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. and removed I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Feb 7, 2025
Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@anomiex anomiex merged commit 3b6380e into trunk Feb 7, 2025
73 checks passed
@anomiex anomiex deleted the add/ci-dont-care-about-coverage-label branch February 7, 2025 19:54
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants