Optimize scan data by ensuring we only call it once per page load

[CodeyGuyDylan]

Proposed changes:

Right now we are calling the Scan API multiple times. Once when we are gathering scan data for the card, and once when checking for scan threats.

• Add an initializer class to the Protect class that calls the Scan endpoint and populates a $scan_data variable
• Update uses of scan data to get the data from this variable instead of calling the same endpoint for different uses of the data

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

1. Checkout this branch via the Jetpack Beta plugin or your local dev environment
2. Install/activate Jetpack Protect with a paid Scan upgrade/plan
3. Go to My Jetpack and, using the Query Monitor, ensure that we are only making one http request to the Scan endpoint
   

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/transient-to-cache-protect-api-calls branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack add/transient-to-cache-protect-api-calls
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[github-actions]

Code Coverage Summary

Coverage changed in 4 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/my-jetpack/src/class-initializer.php	52/499 (10.42%)	-0.02%	1 💔
projects/packages/my-jetpack/src/products/class-protect.php	120/146 (82.19%)	4.77%	-9 💚
projects/packages/my-jetpack/src/products/class-scan.php	28/35 (80.00%)	24.00%	-15 💚
projects/packages/my-jetpack/src/products/class-search.php	61/87 (70.11%)	10.89%	-16 💚

Full summary · PHP report · JS report

[CodeyGuyDylan]

This function was not being used anywhere

[CodeyGuyDylan]

We weren't using the scan class really at all, this probably wasn't being called in any scenario, but just in case, I figured I'd remove it

[CodeyGuyDylan]

Not being used

[elliottprogrammer]

Works as described. Thanks for cleaning this up @CodeyGuyDylan! This looks good to me!
LGTM! 👍