Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms: Update date picker input to use a accessible standalone date picker #41650

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

enejb
Copy link
Member

@enejb enejb commented Feb 7, 2025

⚠️ - This Pr Needs more testing.

Fixes #41081

Screenshot 2025-02-07 at 1 34 14 PM

Proposed changes:

  • This Pr does 2 things.
    1. Adds a new date picker library that is based on the work https://chrisdavies.github.io/tiny-date-picker/
    1. the library was updated to be more accessible and remove any not used features.
  • Removes the current use of the jQuery datepicker usage.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Load this PR.
  • Add a form with 3 date pickers. Each should have a different date format.
  • Load the PR in the front-end and play around with the date pickers.
  • You should be able to select the dates and submit the form as expected.
  • You should be able to use the keyboard to select a date.
  • You should be able to Use VoiceOver on a mac to select a date with your eyes closed.

@enejb enejb added [Status] Needs Testing We need to add this change to the testing call for this month's release [Status] Needs Team Review [Block] Contact Form Form block (also see Contact Form label) [Package] Forms labels Feb 7, 2025
@github-actions github-actions bot added [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/date-picker-input-try-2 branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/date-picker-input-try-2
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/date-picker-input-try-2
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 7, 2025
@enejb enejb added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/js/accessible-form.js 241/387 (62.27%) -1.73% 11 💔
projects/packages/forms/src/contact-form/class-contact-form-field.php 382/538 (71.00%) 2.39% 0 💚

14 files are newly checked for coverage. Only the first 5 are listed here.

File Coverage
projects/packages/forms/src/contact-form/js/date-picker.js 0/3 (0.00%) 💔
projects/packages/forms/src/contact-form/libs/date-picker/date-picker-options.ts 0/45 (0.00%) 💔
projects/packages/forms/src/contact-form/libs/date-picker/date-picker.ts 0/7 (0.00%) 💔
projects/packages/forms/src/contact-form/libs/date-picker/lib/date.ts 0/34 (0.00%) 💔
projects/packages/forms/src/contact-form/libs/date-picker/lib/dom.ts 0/4 (0.00%) 💔

Full summary · PHP report · JS report

@enejb enejb force-pushed the update/date-picker-input-try-2 branch from a804301 to 90160d4 Compare February 8, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review [Status] Needs Testing We need to add this change to the testing call for this month's release [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forms: get rid of jQuery for date picker
1 participant