Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling: Plugin release script tweaks #41651

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Feb 7, 2025

This addresses two quirks/bugs I discovered during the last release cycle:

  1. We have a check to verify the provided version number is higher than the current version number. The check works, but the wording indicates the version is less than current if it's really equal, so this adjusts the wording.
  2. We set GITBASE in the first step to later calculate which packages should have been updated. If we start on some step other than the first one, the GITBASE var wasn't populated. Originally we used git rev-parse --verify HEAD, but since things could happen in the meantime now with the script supporting resumption, I've switched it to git merge-base trunk HEAD, which I believe should give the same thing.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Do the changes I made make sense?

@tbradsha tbradsha added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Feb 7, 2025
@tbradsha tbradsha requested a review from a team February 7, 2025 21:49
@tbradsha tbradsha self-assigned this Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant