Regenerate Lint warnings in release builds

Automattic · Sep 16, 2024 · 26dc493 · 26dc493
1 parent 83a9b2d
commit 26dc493
Show file tree

Hide file tree

Showing 3 changed files with 115 additions and 0 deletions.
diff --git a/app/lint-baseline.xml b/app/lint-baseline.xml
@@ -1849,6 +1849,17 @@
             column="22"/>
     </issue>
 
+    <issue
+        id="ModifierParameter"
+        message="Modifier parameter should be the first optional parameter"
+        errorLine1="    modifier: Modifier = Modifier,"
+        errorLine2="    ~~~~~~~~">
+        <location
+            file="src/main/java/au/com/shiftyjelly/pocketcasts/compose/components/ClickableTextHelper.kt"
+            line="38"
+            column="5"/>
+    </issue>
+
     <issue
         id="ModifierParameter"
         message="Modifier parameter should be the first optional parameter"
@@ -1948,6 +1959,17 @@
             column="36"/>
     </issue>
 
+    <issue
+        id="ReturnFromAwaitPointerEventScope"
+        message="Returning from awaitPointerEventScope may cause some input events to be dropped"
+        errorLine1="                        awaitPointerEventScope {"
+        errorLine2="                        ~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/au/com/shiftyjelly/pocketcasts/endofyear/StoriesPage.kt"
+            line="441"
+            column="25"/>
+    </issue>
+
     <issue
         id="SwitchIntDef"
         message="Switch statement on an `int` with known associated constant missing case `PlaybackStateCompat.STATE_CONNECTING`, `PlaybackStateCompat.STATE_FAST_FORWARDING`, `PlaybackStateCompat.STATE_REWINDING`, `PlaybackStateCompat.STATE_SKIPPING_TO_NEXT`, `PlaybackStateCompat.STATE_SKIPPING_TO_PREVIOUS`, `PlaybackStateCompat.STATE_SKIPPING_TO_QUEUE_ITEM`"

diff --git a/automotive/lint-baseline.xml b/automotive/lint-baseline.xml
@@ -1365,6 +1365,17 @@
             column="22"/>
     </issue>
 
+    <issue
+        id="ModifierParameter"
+        message="Modifier parameter should be the first optional parameter"
+        errorLine1="    modifier: Modifier = Modifier,"
+        errorLine2="    ~~~~~~~~">
+        <location
+            file="src/main/java/au/com/shiftyjelly/pocketcasts/compose/components/ClickableTextHelper.kt"
+            line="38"
+            column="5"/>
+    </issue>
+
     <issue
         id="ModifierParameter"
         message="Modifier parameter should be the first optional parameter"
@@ -1431,6 +1442,17 @@
             column="5"/>
     </issue>
 
+    <issue
+        id="ReturnFromAwaitPointerEventScope"
+        message="Returning from awaitPointerEventScope may cause some input events to be dropped"
+        errorLine1="                        awaitPointerEventScope {"
+        errorLine2="                        ~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/au/com/shiftyjelly/pocketcasts/endofyear/StoriesPage.kt"
+            line="441"
+            column="25"/>
+    </issue>
+
     <issue
         id="SwitchIntDef"
         message="Switch statement on an `int` with known associated constant missing case `PlaybackStateCompat.STATE_CONNECTING`, `PlaybackStateCompat.STATE_FAST_FORWARDING`, `PlaybackStateCompat.STATE_REWINDING`, `PlaybackStateCompat.STATE_SKIPPING_TO_NEXT`, `PlaybackStateCompat.STATE_SKIPPING_TO_PREVIOUS`, `PlaybackStateCompat.STATE_SKIPPING_TO_QUEUE_ITEM`"

diff --git a/wear/lint-baseline.xml b/wear/lint-baseline.xml
@@ -1354,6 +1354,55 @@
             column="50"/>
     </issue>
 
+    <issue
+        id="UnsafeOptInUsageError"
+        message="This declaration is opt-in and its usage should be marked with `@com.google.android.horologist.annotations.ExperimentalHorologistApi` or `@OptIn(markerClass = com.google.android.horologist.annotations.ExperimentalHorologistApi.class)`">
+        <location
+            file="src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/player/NowPlayingViewModel.kt"/>
+    </issue>
+
+    <issue
+        id="UnsafeOptInUsageError"
+        message="This declaration is opt-in and its usage should be marked with `@com.google.android.horologist.annotations.ExperimentalHorologistApi` or `@OptIn(markerClass = com.google.android.horologist.annotations.ExperimentalHorologistApi.class)`">
+        <location
+            file="src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/player/NowPlayingViewModel.kt"/>
+    </issue>
+
+    <issue
+        id="UnsafeOptInUsageError"
+        message="This declaration is opt-in and its usage should be marked with `@com.google.android.horologist.annotations.ExperimentalHorologistApi` or `@OptIn(markerClass = com.google.android.horologist.annotations.ExperimentalHorologistApi.class)`">
+        <location
+            file="src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/player/NowPlayingViewModel.kt"/>
+    </issue>
+
+    <issue
+        id="UnsafeOptInUsageError"
+        message="This declaration is opt-in and its usage should be marked with `@com.google.android.horologist.annotations.ExperimentalHorologistApi` or `@OptIn(markerClass = com.google.android.horologist.annotations.ExperimentalHorologistApi.class)`">
+        <location
+            file="src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/networking/PocketCastsNetworkingRules.kt"/>
+    </issue>
+
+    <issue
+        id="UnsafeOptInUsageError"
+        message="This declaration is opt-in and its usage should be marked with `@com.google.android.horologist.annotations.ExperimentalHorologistApi` or `@OptIn(markerClass = com.google.android.horologist.annotations.ExperimentalHorologistApi.class)`">
+        <location
+            file="src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/networking/PocketCastsNetworkingRules.kt"/>
+    </issue>
+
+    <issue
+        id="UnsafeOptInUsageError"
+        message="This declaration is opt-in and its usage should be marked with `@com.google.android.horologist.annotations.ExperimentalHorologistApi` or `@OptIn(markerClass = com.google.android.horologist.annotations.ExperimentalHorologistApi.class)`">
+        <location
+            file="src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/networking/PocketCastsNetworkingRules.kt"/>
+    </issue>
+
+    <issue
+        id="UnsafeOptInUsageError"
+        message="This declaration is opt-in and its usage should be marked with `@com.google.android.horologist.annotations.ExperimentalHorologistApi` or `@OptIn(markerClass = com.google.android.horologist.annotations.ExperimentalHorologistApi.class)`">
+        <location
+            file="src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/networking/PocketCastsNetworkingRules.kt"/>
+    </issue>
+
     <issue
         id="ComposableNaming"
         message="Composable functions that return Unit should start with an uppercase letter"
@@ -1398,6 +1447,17 @@
             column="22"/>
     </issue>
 
+    <issue
+        id="ModifierParameter"
+        message="Modifier parameter should be the first optional parameter"
+        errorLine1="    modifier: Modifier = Modifier,"
+        errorLine2="    ~~~~~~~~">
+        <location
+            file="src/main/java/au/com/shiftyjelly/pocketcasts/compose/components/ClickableTextHelper.kt"
+            line="38"
+            column="5"/>
+    </issue>
+
     <issue
         id="ModifierParameter"
         message="Modifier parameter should be the first optional parameter"
@@ -1475,6 +1535,17 @@
             column="5"/>
     </issue>
 
+    <issue
+        id="ReturnFromAwaitPointerEventScope"
+        message="Returning from awaitPointerEventScope may cause some input events to be dropped"
+        errorLine1="                        awaitPointerEventScope {"
+        errorLine2="                        ~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/java/au/com/shiftyjelly/pocketcasts/endofyear/StoriesPage.kt"
+            line="441"
+            column="25"/>
+    </issue>
+
     <issue
         id="SwitchIntDef"
         message="Switch statement on an `int` with known associated constant missing case `PlaybackStateCompat.STATE_CONNECTING`, `PlaybackStateCompat.STATE_FAST_FORWARDING`, `PlaybackStateCompat.STATE_REWINDING`, `PlaybackStateCompat.STATE_SKIPPING_TO_NEXT`, `PlaybackStateCompat.STATE_SKIPPING_TO_PREVIOUS`, `PlaybackStateCompat.STATE_SKIPPING_TO_QUEUE_ITEM`"