Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate views: Redirect from Calypso Pages to WP Admin Pages #98148

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jan 9, 2025

Part of #95620

Proposed Changes

Redirects from /pages/:site to /wp-admin/edit.php?post_type=page if the user participates in the "Remove duplicate views" experiment

Why are these changes being made?

Because even if the Pages menu already links to WP Admin, some users might access the Calypso URL directly, so we want to ensure that these users land in WP Admin.

Testing Instructions

  • Assign yourself to the treatment variant of the experiment: 22129-explat-experiment
  • Use the Calypso live link below
  • Go to /pages/:site for a site with the default admin interface
  • Make sure it redirects to WP Admin

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@mmtr mmtr requested a review from a team January 9, 2025 13:52
@mmtr mmtr self-assigned this Jan 9, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 9, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~13 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
pages        +36 B  (+0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/remove-duplicate-views-redirect-pages on your sandbox.

@mmtr mmtr merged commit 2e8e72b into trunk Jan 14, 2025
14 of 15 checks passed
@mmtr mmtr deleted the update/remove-duplicate-views-redirect-pages branch January 14, 2025 08:11
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants