-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Newsletter launchpad for /setup/onboarding Newsletter Goal #98546
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~8 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1721 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~29 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
db66eb2
to
49f0d0d
Compare
@@ -61,6 +61,7 @@ export const LAUNCHPAD_INTENT_HOSTING = 'home-launchpad-intent-hosting'; | |||
export const LAUNCHPAD_INTENT_WRITE = 'home-launchpad-intent-write'; | |||
export const LAUNCHPAD_INTENT_FREE_NEWSLETTER = 'home-launchpad-intent-free-newsletter'; | |||
export const LAUNCHPAD_INTENT_PAID_NEWSLETTER = 'home-launchpad-intent-paid-newsletter'; | |||
export const LAUNCHPAD_INTENT_NEWSLETTER_V2 = 'home-launchpad-intent-newsletter-v2'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of calling it v2, just in case this lives a lot longer than we intend it to, but I get you 😅
Maybe we could call it ...-newsletter-onboarding
? Something to do with the fact that it's the newsletter intent from the onboarding flow? Or maybe newsletter-goals
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.
if ( goals.includes( SiteGoal.Newsletter ) ) { | ||
return SiteIntent.NewsletterV2; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should throw a feature flag around this? It'd allow us to merge this PR then give a link to Autumn et al to show it working?
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested and lgtm
Related to #96384
Proposed Changes
Added Newsletter Goal Launchpad to /home
Why are these changes being made?
Testing Instructions
I've only tested on Simple Sites for now
public-api.wordpress.com
/setup/onboarding?flags=onboarding/newsletter-goal
Pre-merge Checklist