Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Newsletter launchpad for /setup/onboarding Newsletter Goal #98546

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

candy02058912
Copy link
Contributor

@candy02058912 candy02058912 commented Jan 17, 2025

Related to #96384

Proposed Changes

Added Newsletter Goal Launchpad to /home

myhome-launchpad@2x

Why are these changes being made?

  • pet6gk-1Po-p2

Testing Instructions

I've only tested on Simple Sites for now

  • Sandbox public-api.wordpress.com
  • Apply related backend code in 170645-ghe-Automattic/wpcom
  • Follow instructions Update onboarding newsletter goal tasks jetpack#41158 (comment) to get the jetpack code into sandbox
  • Go to /setup/onboarding?flags=onboarding/newsletter-goal
  • Choose "Create a newsletter" goal
  • Go through the process and you'll land in /home/:site with the launchpad

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@candy02058912 candy02058912 requested a review from a team January 17, 2025 14:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 17, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 17, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~8 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +42 B  (+0.0%)       +8 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1721 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
preview                              +4904 B  (+1.6%)    +1572 B  (+1.7%)
home                                  +160 B  (+0.0%)      +44 B  (+0.0%)
site-setup-wg                         +141 B  (+0.0%)      +62 B  (+0.1%)
onboarding-flow                       +133 B  (+0.5%)      +43 B  (+0.5%)
reader                                 +53 B  (+0.0%)      +18 B  (+0.0%)
plugins                                +53 B  (+0.0%)      +18 B  (+0.0%)
jetpack-cloud-plugin-management        +53 B  (+0.0%)      +18 B  (+0.0%)
subscribers                            +42 B  (+0.0%)      +14 B  (+0.0%)
staging-site                           +42 B  (+0.0%)      +14 B  (+0.0%)
site-tools                             +42 B  (+0.0%)      +14 B  (+0.0%)
site-settings                          +42 B  (+0.0%)      +14 B  (+0.0%)
settings                               +42 B  (+0.0%)      +14 B  (+0.0%)
checkout                               +42 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~29 bytes added 📈 [gzipped])

name                                                parsed_size           gzip_size
async-load-calypso-blocks-jitm-templates-home-task        +53 B  (+0.1%)      +15 B  (+0.1%)
async-load-signup-steps-plans-theme-preselected           +42 B  (+0.0%)      +14 B  (+0.0%)
async-load-signup-steps-plans                             +42 B  (+0.0%)      +14 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@candy02058912 candy02058912 force-pushed the update/launchpad-goal-tasks branch from db66eb2 to 49f0d0d Compare January 22, 2025 06:21
@candy02058912 candy02058912 changed the title Map newsletter goal to newsletter intent Add Newsletter V2 launchpad for /onboarding Newsletter Goal Jan 22, 2025
@@ -61,6 +61,7 @@ export const LAUNCHPAD_INTENT_HOSTING = 'home-launchpad-intent-hosting';
export const LAUNCHPAD_INTENT_WRITE = 'home-launchpad-intent-write';
export const LAUNCHPAD_INTENT_FREE_NEWSLETTER = 'home-launchpad-intent-free-newsletter';
export const LAUNCHPAD_INTENT_PAID_NEWSLETTER = 'home-launchpad-intent-paid-newsletter';
export const LAUNCHPAD_INTENT_NEWSLETTER_V2 = 'home-launchpad-intent-newsletter-v2';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of calling it v2, just in case this lives a lot longer than we intend it to, but I get you 😅

Maybe we could call it ...-newsletter-onboarding? Something to do with the fact that it's the newsletter intent from the onboarding flow? Or maybe newsletter-goals?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Comment on lines 32 to 34
if ( goals.includes( SiteGoal.Newsletter ) ) {
return SiteIntent.NewsletterV2;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should throw a feature flag around this? It'd allow us to merge this PR then give a link to Autumn et al to show it working?

@candy02058912 candy02058912 marked this pull request as ready for review January 23, 2025 03:03
@p-jackson p-jackson changed the title Add Newsletter V2 launchpad for /onboarding Newsletter Goal Add Newsletter launchpad for /setup/onboarding Newsletter Goal Jan 23, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/launchpad-goal-tasks on your sandbox.

Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested and lgtm

@candy02058912 candy02058912 merged commit 2aebf35 into trunk Jan 23, 2025
13 checks passed
@candy02058912 candy02058912 deleted the update/launchpad-goal-tasks branch January 23, 2025 11:36
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants