Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: add signup multiple steps form #99137

Closed
wants to merge 1 commit into from

Conversation

andrii-lysenko
Copy link
Contributor

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/1728

Proposed Changes

This PR adds new Mutiple step contact form. The main purpose is to have a skeleton, so it's not 100% properly styled yet. Validation is disabled as well.

The main goal is to bootstrap all the steps and attach necessary logic.

This also adds form for the first page.

Screenshot 2025-01-30 at 5 06 04 PM

Why are these changes being made?

Testing Instructions

  • Using live link below navigate to /signup/wc-asia.
  • Check multiple steps by clicking Continue button.
Screen.Recording.2025-01-30.at.5.05.43.PM.mov

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@andrii-lysenko andrii-lysenko added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. A4A labels Jan 31, 2025
@andrii-lysenko andrii-lysenko requested a review from a team January 31, 2025 01:34
@andrii-lysenko andrii-lysenko self-assigned this Jan 31, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug a4a/add-signup-multiple-steps-form on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1217 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
a8c-for-agencies-signup      +5849 B  (+4.1%)    +1217 B  (+2.8%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@yashwin yashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I noticed the background on the video added here is white, whereas it shows a dark background here:

Screenshot 2025-02-03 at 12 56 08 PM

I also left some comments, let me what you think!

>
<div className="signup-multi-step-form__fields">
<div className="signup-multi-step-form__name-fields">
<FormField label={ translate( 'Your first name' ) } isRequired>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use htmlFor for all the fields on this form?

We could use FormLabel that supports it or add the support on the FormField component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noting that. Let's address this one with one of the page tasks, to avoid growing this PR. What do you think?

@andrii-lysenko
Copy link
Contributor Author

@yashwin @jkguidaven Thank you for the reviews. I addressed some of the comments like usage of preventWindows and removing &__ from styles replacing with the full name. As per others, I suggest addressing these on per page basis, as we will improve every page styles and code. What do you think? These include also using htmlFor as it probably require changing the component outside the form itself, so I would like not to grow this PR even more.

I've also change base of this PR to trunk and will close #99137 to avoid problems with merging.

@yashwin yashwin mentioned this pull request Feb 4, 2025
8 tasks
@andrii-lysenko
Copy link
Contributor Author

Closing this PR to avoid confusion. All the changes will be delivered from this PR: #99186

I will take notes on unresolved suggestions on the appropriate tasks. Thank you!

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants