-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: add signup multiple steps form #99137
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1217 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...a8c-for-agencies/sections/signup/signup-v2/components/multi-step-form/contact-form/index.tsx
Show resolved
Hide resolved
> | ||
<div className="signup-multi-step-form__fields"> | ||
<div className="signup-multi-step-form__name-fields"> | ||
<FormField label={ translate( 'Your first name' ) } isRequired> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use htmlFor
for all the fields on this form?
We could use FormLabel
that supports it or add the support on the FormField
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noting that. Let's address this one with one of the page tasks, to avoid growing this PR. What do you think?
...a8c-for-agencies/sections/signup/signup-v2/components/multi-step-form/contact-form/index.tsx
Show resolved
Hide resolved
...8c-for-agencies/sections/signup/signup-v2/components/multi-step-form/contact-form/style.scss
Show resolved
Hide resolved
...8c-for-agencies/sections/signup/signup-v2/components/multi-step-form/contact-form/style.scss
Show resolved
Hide resolved
...8c-for-agencies/sections/signup/signup-v2/components/multi-step-form/contact-form/style.scss
Show resolved
Hide resolved
client/a8c-for-agencies/sections/signup/signup-v2/components/multi-step-form/index.tsx
Show resolved
Hide resolved
client/a8c-for-agencies/sections/signup/signup-v2/components/multi-step-form/style.scss
Show resolved
Hide resolved
client/a8c-for-agencies/sections/signup/signup-v2/components/step-progress/style.scss
Show resolved
Hide resolved
...8c-for-agencies/sections/signup/signup-v2/components/multi-step-form/contact-form/style.scss
Show resolved
Hide resolved
client/a8c-for-agencies/sections/signup/signup-v2/components/step-progress/style.scss
Show resolved
Hide resolved
client/a8c-for-agencies/sections/signup/signup-v2/components/step-progress/style.scss
Show resolved
Hide resolved
@yashwin @jkguidaven Thank you for the reviews. I addressed some of the comments like usage of I've also change base of this PR to |
Closing this PR to avoid confusion. All the changes will be delivered from this PR: #99186 I will take notes on unresolved suggestions on the appropriate tasks. Thank you! |
Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/1728
Proposed Changes
This PR adds new Mutiple step contact form. The main purpose is to have a skeleton, so it's not 100% properly styled yet. Validation is disabled as well.
The main goal is to bootstrap all the steps and attach necessary logic.
This also adds form for the first page.
Why are these changes being made?
Testing Instructions
/signup/wc-asia
.Continue
button.Screen.Recording.2025-01-30.at.5.05.43.PM.mov
Pre-merge Checklist