Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jetpack Carousel settings tests for calypso #99197

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Feb 3, 2025

Fixes #99155

Proposed Changes

  • Removes Jetpack Carousel settings tests for calypso

Why are these changes being made?

Testing Instructions

yarn workspace wp-e2e-tests test -- test/e2e/specs/media/settings__media.ts

@lsl lsl self-assigned this Feb 3, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me!

Should we let some team know about this change?

@lsl lsl merged commit 186fbca into trunk Feb 4, 2025
12 checks passed
@lsl lsl deleted the update/disable-settings-e2e branch February 4, 2025 00:01
@lsl
Copy link
Contributor Author

lsl commented Feb 4, 2025

Should we let some team know about this change?

The test was added by Edwin so I'm assuming Jetpack has no knowledge or interest in this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: Disable E2E tests for calypso site settings
3 participants