Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E TOTP auth test: Replace /settings/general redirect target with /plans #99198

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Feb 3, 2025

Fixes #99155

Proposed Changes

  • The /settings/general calypso route is moving / being untangled. Since we don't know if that route will be around much longer, I'm updating this to look for a /plans redirect which is much more likely to survive untangling.
  • The sleep for the woo test needed moving as it was causing a failure

Testing Instructions

yarn workspace wp-e2e-tests test -- test/e2e/specs/authentication/authentication__totp.ts

@lsl lsl self-assigned this Feb 3, 2025
Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@lsl lsl merged commit 03c2611 into trunk Feb 4, 2025
13 checks passed
@lsl lsl deleted the update/settings-e2e-totp branch February 4, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: Disable E2E tests for calypso site settings
3 participants