feat: Use full IPA recursive verifier in root rollup #10962
Conversation
| @@ -270,9 +273,8 @@ void build_constraints(Builder& builder, AcirProgram& program, const ProgramMeta | |||
| // final recursion output. | |||
| builder.add_pairing_point_accumulator(current_aggregation_object); | |||
| } | |||
| // TODO(https://github.com/AztecProtocol/barretenberg/issues/1183): This assertion should be true, except for | |||
There was a problem hiding this comment.
honk_recursion is 2 for the tube, base, merge, block root, block merge circuits, but NOT the root rollup.
This assert previously wasn't true because the root rollup wasn't running the full verifier and therefore still spit out an ipa claim and proof, but now that it does run full verification, it will output nothing.
| @@ -379,13 +381,17 @@ HonkRecursionConstraintsOutput<Builder> process_honk_recursion_constraints( | |||
| size_t idx = 0; | |||
| std::vector<OpeningClaim<stdlib::grumpkin<Builder>>> nested_ipa_claims; | |||
| std::vector<StdlibProof<Builder>> nested_ipa_proofs; | |||
| bool is_root_rollup = false; | |||
There was a problem hiding this comment.
this bool checks to see if any of the honk recursion constraints set the proof type to be ROOT ROLLUP HONK and that's how we know whether to run the full IPA recursive verifier or not.
| @@ -400,6 +406,7 @@ HonkRecursionConstraintsOutput<Builder> process_honk_recursion_constraints( | |||
| gate_counter.track_diff(constraint_system.gates_per_opcode, | |||
| constraint_system.original_opcode_indices.honk_recursion_constraints.at(idx++)); | |||
| } | |||
| ASSERT(!(is_root_rollup && nested_ipa_claims.size() != 2) && "Root rollup must accumulate two IPA proofs."); | |||
There was a problem hiding this comment.
just checking to make sure that if its the root rollup, we have 2 nested IPA claims to accumulate
| // do full IPA verification | ||
| auto accumulated_ipa_transcript = | ||
| std::make_shared<StdlibTranscript>(convert_native_proof_to_stdlib(&builder, ipa_proof)); | ||
| IPA<stdlib::grumpkin<Builder>>::full_verify_recursive( |
There was a problem hiding this comment.
if root rollup, run full IPA recursive verifier, otherwise return the ipa claim and proof as output
| @@ -635,7 +635,7 @@ void handle_blackbox_func_call(Program::Opcode::BlackBoxFuncCall const& arg, | |||
| // be the only means for setting the proof type. use of honk_recursion flag in this context can go | |||
| // away once all noir programs (e.g. protocol circuits) are updated to use the new pattern. | |||
| if (proof_type_in != HONK && proof_type_in != AVM && proof_type_in != ROLLUP_HONK && | |||
| proof_type_in != ROLLUP_ROOT_HONK) { | |||
| proof_type_in != ROOT_ROLLUP_HONK) { | |||
| impl Verifiable for PreviousRollupBlockData { | ||
| fn verify(self) { | ||
| impl PreviousRollupBlockData { | ||
| fn verify(self, proof_type_id: u32) { |
There was a problem hiding this comment.
adding an extra argument because this function is shared between the root rollup and the block merge
| self.previous_rollup_data[0].validate_in_vk_tree(ALLOWED_PREVIOUS_CIRCUITS); | ||
|
|
||
| self.previous_rollup_data[1].verify(); | ||
| self.previous_rollup_data[1].verify(PROOF_TYPE_ROOT_ROLLUP_HONK); |
There was a problem hiding this comment.
core change: this is the ROOT_ROLLUP_HONK type
Modifies the root rollup circuit to use different recursion proof type, ROOT_ROLLUP_HONK and processing of honk_recursion_constraints, so the backend knows to run the full IPA recursive verifier. Resolves AztecProtocol/barretenberg#1183.
Modifies the root rollup circuit to use different recursion proof type, ROOT_ROLLUP_HONK and processing of honk_recursion_constraints, so the backend knows to run the full IPA recursive verifier.
Resolves AztecProtocol/barretenberg#1183.