fix: Incorrect check of the error object's property #10969
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this code snippet, there is a check for compilation errors after calling
solc.compile
. However, the Solidity compiler (solc
) returns error objects with aseverity
field, nottype
. Theseverity
field can have values"error"
or"warning"
. Therefore, the check should be directed ate.severity
instead ofe.type
.Due to the incorrect check
e.type == "Error"
, compilation errors may go undetected. This will cause the code to continue executing even in the presence of critical compilation errors, which can lead to unpredictable program behavior, improper deployment of smart contracts, or other serious issues.