Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update video_chatcompletions_example_restapi.ipynb #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jfilcik
Copy link

@jfilcik jfilcik commented Jul 2, 2024

update comments to describe the new code.

Description

Checklist "# Sample 10 frames from the video file using pymovie library",

  • I have read the contribution guidelines
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

update comments to describe the new code.
@jfilcik jfilcik requested a review from a team as a code owner July 2, 2024 18:42
@jfilcik
Copy link
Author

jfilcik commented Jul 2, 2024

@steeler18 can you review?

@@ -193,9 +193,12 @@
"local_file_path = \"downloaded_video.mp4\"\n",
"assert download_video(video_SAS_url, local_file_path), \"Failed to download video.\"\n",
"\n",
"# Sample 10 frames from the video file using pymovie library",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is moviepy libary.

@@ -168,7 +168,7 @@
"id": "feabcd3f",
"metadata": {},
"source": [
"### Call GPT-4 Turbo with Vision API"
"### Sample frame and call GPT-4 Turbo"
Copy link
Contributor

@steeler18 steeler18 Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "Sample frames"?

Also need to do similar change in video_chunk_chatcompletions_example_restapi.ipynb and in scenarios/GPT-4V/README.md (line 16 and line 18)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants