Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outbound exception issue fix. #11

Open
wants to merge 2 commits into
base: feature/communication-CallingServer-preview
Choose a base branch
from
Open

Outbound exception issue fix. #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92a2913
Issue 155: Python Outbound: Got exception
v-maku23 Dec 24, 2021
13aebca
Merge pull request #1 from moirf/v-maku23/outbound_sample_issues
Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions OutboundCallReminder/Ngrok/NgrokService.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import psutil
import signal
from pathlib import Path
from subprocess import CREATE_NEW_CONSOLE


class NgrokService:
Expand Down Expand Up @@ -57,8 +58,7 @@ def create_ngrok_process(self, ngrokPath, authToken):

executable = str(Path(ngrokPath, "ngrok.exe"))
os.chmod(executable, 0o777)
self.__ngrokProcess = subprocess.Popen(
[executable, "http", "http://localhost:9007/", "-host-header", "localhost:9007"])
self.__ngrokProcess = subprocess.Popen([executable, "http", "http://localhost:9007/", "-host-header", "localhost:9007"],creationflags=CREATE_NEW_CONSOLE)

# <summary>
# Get Ngrok URL
Expand Down
5 changes: 4 additions & 1 deletion OutboundCallReminder/OutboundCallReminder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,10 @@ def add_participant(self, addedParticipant):
add_participant_response: AddParticipantResult = self.call_connection.add_participant(participant=participant,
alternate_caller_id=alternate_caller_id, operation_context=operation_context)
Logger.log_message(
Logger.INFORMATION, "addParticipantWithResponse -- > " + add_participant_response.participant_id)
Logger.INFORMATION, "addParticipantWithResponse -- > " + add_participant_response.additional_properties.get("operationId"))

Logger.log_message(
Logger.INFORMATION, "addParticipantWithResponse -- > " + add_participant_response.additional_properties.get("status"))

def register_to_add_participants_result_event(self, operation_context):
if(self.add_participant_complete_task):
Expand Down