Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric E2E Sample] Add script to upload config file and seed data #992

Conversation

maye-msft
Copy link
Contributor

@maye-msft maye-msft commented Dec 25, 2024

Type of PR

  • Code changes

Purpose

  • The PR is to add the part of IaC of uploading the config file and seed data in to sc-adls-main:
    - Files/sc-adls-main/config/lakehouse_ddls.yaml
    - Files/sc-adls-main/config/application.cfg (derived using application.cfg.template during ci/cd process).
    - Files/sc-adls-main/reference/dim_date.csv
    - Files/sc-adls-main/reference/dim_time.csv

Does this introduce a breaking change? If yes, details on what can break

No.

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Run the ./deploy.sh and check the following files in the storage account and container:
    • config/lakehouse_ddls.yaml
    • config/application.cfg
    • reference/dim_date.csv
    • reference/dim_time.csv

Issues Closed or Referenced

@promisinganuj promisinganuj changed the title add script to upload config file and seed data [Fabric E2E Sample] Add script to upload config file and seed data Dec 31, 2024
@promisinganuj promisinganuj requested review from naga-nandyala and removed request for jose-perales December 31, 2024 04:41
Copy link
Contributor

@promisinganuj promisinganuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Looking for another approval.

Copy link
Contributor

@naga-nandyala naga-nandyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes looks fine.. Approved the PR.

did a fresh deployment with this branch & ran the data pipeline to test all config and reference data upload changes.

@promisinganuj promisinganuj merged commit a57de41 into feat/e2e-fabric-dataops-sample-v0-2 Jan 1, 2025
3 checks passed
@promisinganuj promisinganuj deleted the kitsune/upload-config-files-to-adls branch January 1, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e: fabric Related with E2E Fabric Sample
Projects
None yet
3 participants