Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fabric E2E Sample] ddo transform module upload #994

Merged
merged 4 commits into from
Jan 2, 2025
Merged

[Fabric E2E Sample] ddo transform module upload #994

merged 4 commits into from
Jan 2, 2025

Conversation

yuna-s
Copy link

@yuna-s yuna-s commented Dec 26, 2024 •
edited
Loading

Type of PR

  • Code changes
  • Test changes
  • Test Data changes

Purpose

  • Upload ddo_transform python file to fabric environment
  • Update tests for ddo_transform python file

Does this introduce a breaking change? If yes, details on what can break

No

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Execute tests on ddo_transform python file to ensure it is working as expected. Tests files are placed under modern-data-warehouse-dataops/e2e_samples/fabric_dataops_sample/src/tests.
  • Execute deploy.sh command and see if ddo_transform python file is uploaded to fabric environment

Issues Closed or Referenced

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@yuna-s yuna-s self-assigned this Dec 26, 2024
@yuna-s yuna-s changed the title ddo transform module upload [Fabric E2E Sample] ddo transform module upload Dec 26, 2024
@promisinganuj promisinganuj self-requested a review December 29, 2024 23:51
@promisinganuj promisinganuj added the e2e: fabric Related with E2E Fabric Sample label Dec 29, 2024
@promisinganuj promisinganuj linked an issue Dec 29, 2024 that may be closed by this pull request
Upload ddo transform to fabric #987
Open
3 tasks
promisinganuj
promisinganuj approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@promisinganuj promisinganuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yuna-s yuna-s merged commit 53af889 into kitsune/notebook_and_pipeline_updates Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@promisinganuj promisinganuj promisinganuj approved these changes

Assignees

@yuna-s yuna-s

Labels
e2e: fabric Related with E2E Fabric Sample
Projects
None yet
Milestone
E2E - parking_sensor_fabric - V1
Development

Successfully merging this pull request may close these issues.

Upload ddo transform to fabric
2 participants
@yuna-s @promisinganuj