Fix: add build
script to postinstall
script
#121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Purpose
This PR adds a
npm run build
script topostinstall
script in/1-Authentication/1-Sign-in/App/package.json
, to solve the following problem when runningnpm start
This bug is because it's the first time I run
npm start
in any chapter, the helper inside/Common
hasn't been built before.Actually, we need to add
npm run build
to everypostinstall
in case of the above bug, but this PR just adds for/1-Authentication/1-sign-in/
.Does this introduce a breaking change
Pull request type
What kind of change does this Pull Request introduce?
How to test
What to check
ex: verify that the following are valid:
npm start
Other Information
Related issue: Please Fix the following issue I was having when running npm start in sample \4-AccessControl\2-security-groups · Issue #100 · Azure-Samples/ms-identity-javascript-nodejs-tutorial