{Compute} az sig gallery-application: Migrate to aaz
#30678
+1,295
−373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| sig gallery-application create | cmd sig gallery-application create update parameter description: added property aaz_type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter description: added property type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter gallery_application_name: added property aaz_type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter gallery_application_name: added property type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter gallery_application_name: updated property options from ['--application-name', '--name', '-n'] to ['--application-name', '--gallery-application-name', '--name', '-n'] |
||
| sig gallery-application create | cmd sig gallery-application create update parameter gallery_name: added property aaz_type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter gallery_name: added property type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter location: added property aaz_type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter location: updated property type from custom_type to string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter no_wait: added property aaz_type=bool |
||
| sig gallery-application create | cmd sig gallery-application create update parameter no_wait: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| sig gallery-application create | cmd sig gallery-application create update parameter no_wait: added property nargs=? |
||
| sig gallery-application create | cmd sig gallery-application create update parameter no_wait: added property type=bool |
||
| sig gallery-application create | cmd sig gallery-application create update parameter os_type: added property aaz_type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter os_type: added property type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter resource_group_name: added property aaz_type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter resource_group_name: added property type=string |
||
| sig gallery-application create | cmd sig gallery-application create update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| sig gallery-application create | cmd sig gallery-application create update parameter tags: added property aaz_type=AAZDictArg |
||
| sig gallery-application create | cmd sig gallery-application create update parameter tags: added property type=Dict<String,String> |
||
| sig gallery-application create | cmd sig gallery-application create update parameter tags: updated property nargs from * to + |
||
| sig gallery-application list | cmd sig gallery-application list added parameter pagination_limit |
||
| sig gallery-application list | cmd sig gallery-application list added parameter pagination_token |
||
| sig gallery-application update | cmd sig gallery-application update added parameter generic_update_add |
||
| sig gallery-application update | cmd sig gallery-application update added parameter generic_update_force_string |
||
| sig gallery-application update | cmd sig gallery-application update added parameter generic_update_remove |
||
| sig gallery-application update | cmd sig gallery-application update added parameter generic_update_set |
||
| sig gallery-application update | cmd sig gallery-application update update parameter description: added property aaz_type=string |
||
| sig gallery-application update | cmd sig gallery-application update update parameter description: added property type=string |
||
| sig gallery-application update | cmd sig gallery-application update update parameter gallery_application_name: added property aaz_type=string |
||
| sig gallery-application update | cmd sig gallery-application update update parameter gallery_application_name: added property id_part=child_name_1 |
||
| sig gallery-application update | cmd sig gallery-application update update parameter gallery_application_name: added property type=string |
||
| sig gallery-application update | cmd sig gallery-application update update parameter gallery_application_name: updated property options from ['--application-name', '--name', '-n'] to ['--application-name', '--gallery-application-name', '--name', '-n'] |
||
| sig gallery-application update | cmd sig gallery-application update update parameter gallery_name: added property aaz_type=string |
||
| sig gallery-application update | cmd sig gallery-application update update parameter gallery_name: added property id_part=name |
||
| sig gallery-application update | cmd sig gallery-application update update parameter gallery_name: added property type=string |
||
| sig gallery-application update | cmd sig gallery-application update update parameter location: added property aaz_type=string |
||
| sig gallery-application update | cmd sig gallery-application update update parameter location: updated property type from custom_type to string |
||
| sig gallery-application update | cmd sig gallery-application update update parameter no_wait: added property aaz_type=bool |
||
| sig gallery-application update | cmd sig gallery-application update update parameter no_wait: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| sig gallery-application update | cmd sig gallery-application update update parameter no_wait: added property nargs=? |
||
| sig gallery-application update | cmd sig gallery-application update update parameter no_wait: added property type=bool |
||
| sig gallery-application update | cmd sig gallery-application update update parameter resource_group_name: added property aaz_type=string |
||
| sig gallery-application update | cmd sig gallery-application update update parameter resource_group_name: added property type=string |
||
| sig gallery-application update | cmd sig gallery-application update update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| sig gallery-application update | cmd sig gallery-application update update parameter tags: added property aaz_type=AAZDictArg |
||
| sig gallery-application update | cmd sig gallery-application update update parameter tags: added property type=Dict<String,String> |
||
| sig gallery-application update | cmd sig gallery-application update update parameter tags: updated property nargs from * to + |
||
| sig gallery-application wait | cmd sig gallery-application wait update parameter gallery_application_name: added property aaz_type=string |
||
| sig gallery-application wait | cmd sig gallery-application wait update parameter gallery_application_name: added property id_part=child_name_1 |
||
| sig gallery-application wait | cmd sig gallery-application wait update parameter gallery_application_name: added property type=string |
||
| sig gallery-application wait | cmd sig gallery-application wait update parameter gallery_application_name: updated property options from ['--application-name', '--name', '-n'] to ['--application-name', '--gallery-application-name', '--name', '-n'] |
||
| sig gallery-application wait | cmd sig gallery-application wait update parameter gallery_name: added property aaz_type=string |
||
| sig gallery-application wait | cmd sig gallery-application wait update parameter gallery_name: added property id_part=name |
||
| sig gallery-application wait | cmd sig gallery-application wait update parameter gallery_name: added property type=string |
||
| sig gallery-application wait | cmd sig gallery-application wait update parameter resource_group_name: added property aaz_type=string |
||
| sig gallery-application wait | cmd sig gallery-application wait update parameter resource_group_name: added property type=string |
||
| sig gallery-application wait | cmd sig gallery-application wait update parameter resource_group_name: updated property name from resource_group_name to resource_group |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan,
zhoxing-ms and
yanzhudd
microsoft-github-policy-service
bot
added
the
Compute
yanzhudd
reviewed
Jan 22, 2025
yanzhudd
reviewed
Jan 22, 2025
| self.cmd('sig create -r {gallery} -g {rg}') | ||
| self.cmd('sig gallery-application update -n {app_name} -r {gallery} -g {rg} --description test --tags tag=test', checks=[ | ||
| self.check('name', '{app_name}'), | ||
| self.check('supportedOsType', 'Windows'), | ||
| self.check('supportedOSType', 'Windows'), |
There was a problem hiding this comment.
since the output field has been changed and it is actually a breaking change, it is better to add a changelog to the History Notes section like this:
|
please remember to raise an AAZ PR as well |
Co-authored-by: Yan Zhu <[email protected]>
|
It is better to list all the migrated commands of this PR in the Description section |
|
Are the commands only existed in the latest profile? |
Yes, only in latest profile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sig gallery-application create/delete/list/show/update/waitDescription
aaz pr Azure/aaz#676
Testing Guide
History Notes
[Compute] BREAKING CHANGE:
az sig gallery-application create/update: Output fieldsupportedOsTypechanged tosupportedOSTypeThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.