-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{RDBMS} az postgres flexible-server backup create
: add backup name validator
#30687
Open
mattboentoro
wants to merge
1
commit into
Azure:dev
Choose a base branch
from
mattboentoro:mattboentoro/backup-name-validator
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
{RDBMS} az postgres flexible-server backup create
: add backup name validator
#30687
mattboentoro
wants to merge
1
commit into
Azure:dev
from
mattboentoro:mattboentoro/backup-name-validator
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔄AzureCLI-FullTest
|
Hi @mattboentoro, |
Validation for Breaking Change Starting...
Thanks for your contribution! |
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007,
jsntcy and
zhoxing-ms
January 21, 2025 19:24
mattboentoro
requested review from
nachoalonsoportillo
and removed request for
jsntcy,
zhoxing-ms,
wangzelin007 and
yonzhan
January 21, 2025 19:26
nasc17
approved these changes
Jan 21, 2025
nachoalonsoportillo
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
evelyn-ys
approved these changes
Jan 22, 2025
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server backup create
Description
Add backup name validator
Testing Guide
Manual testing
History Notes
{RDBMS}
az postgres flexible-server backup create
: add backup name validatorThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.