Skip to content
This repository has been archived by the owner on Mar 20, 2019. It is now read-only.

Android sample: Removing SenderId from secrets.properties #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Android sample: Removing SenderId from secrets.properties #71

wants to merge 1 commit into from

Conversation

kmiecikt
Copy link
Contributor

@kmiecikt kmiecikt commented Feb 5, 2019

The secretId is not needed to send notifications using FCM.

This PR contains two changes:

  1. Removes secretId handling from the build.gradle (which processes the local secrets.properties)
  2. Removes call to NotificationsManager.handleNotification from the NotificationHelper.

@kylekampy
Copy link

@kmiecikt - can you explain #2 a little bit? Was it just extraneous?

@brannon
Copy link
Contributor

brannon commented Mar 6, 2019

@kmiecikt can you port this PR to the new android repo?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylekampy kylekampy kylekampy approved these changes

@brannon brannon Awaiting requested review from brannon

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki

@aimankhan aimankhan Awaiting requested review from aimankhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmiecikt @kylekampy @brannon