Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage to ADAL #1650

Open
wants to merge 25 commits into
base: dev
Choose a base branch
from
Open

Add code coverage to ADAL #1650

wants to merge 25 commits into from

Conversation

paulkagiri
Copy link
Contributor

@paulkagiri paulkagiri commented Oct 4, 2021 •
edited
Loading

  • This PR incorporates the code coverage work done on this PR - https://github.com/AzureAD/android-complete/pull/110 in ADAL
  • It does this by updating the buildsystem plugin within which the code coverage tool is housed in
  • There is also the setup of a pipeline in Azure for running the code coverage which utilizes codecov for populating the results of the code coverage run on the PR it is run from

@paulkagiri paulkagiri requested a review from a team as a code owner October 4, 2021 17:33
AdamBJohnsonx
AdamBJohnsonx reviewed Oct 7, 2021
View reviewed changes
changelog.txt Outdated Show resolved Hide resolved
@paulkagiri paulkagiri self-assigned this Oct 21, 2021
@paulkagiri paulkagiri added the No-Changelog This request does not update the changelog label Oct 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev@c1170df). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #1650   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      74           
  Lines          ?    6520           
  Branches       ?     804           
=====================================
  Hits           ?       0           
  Misses         ?    6520           
  Partials       ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1170df...65e83b6. Read the comment docs.

@paulkagiri
Copy link
Contributor Author

The failing test has been fixed in #1662

shoatman
shoatman approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@shoatman shoatman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI Paul, I'm approving. Please run all automated tests available for ADAL and send out test coverage report. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamBJohnsonx AdamBJohnsonx AdamBJohnsonx approved these changes

@gitaumoses4 gitaumoses4 gitaumoses4 approved these changes

@shoatman shoatman shoatman approved these changes

@tanmaymanolkar1 tanmaymanolkar1 Awaiting requested review from tanmaymanolkar1

At least 2 approving reviews are required to merge this pull request.

Assignees

@paulkagiri paulkagiri

Labels
No-Changelog This request does not update the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paulkagiri @codecov-commenter @shoatman @gitaumoses4 @AdamBJohnsonx @tanmaymanolkar1