Handle error gracefully when app url scheme is not found

[denniskniep]

Can we add an error handler to the AmazonAppUri processing? So that if someone does not have the app yet installed it is not crashing the authentication process? Then an hint can be displayed, that the app should be installed.

cc: @shahzaibj

[denniskniep]

@microsoft-github-policy-service agree

[shahzaibj]

@denniskniep I'm not sure what a hint could be for installing the app. Is the app on PlayStore and/or is there a URL for downloading this app?

[denniskniep]

Then an hint can be displayed, that the app should be installed.

@shahzaibj What I meant with that was:
Currently the authentication process crashes entirely, which means the actual website is not visible anymore to the user, therefore the authentication process can not render any guidance to the user to resolve that issue. A potential guidance from the authentication process could be a hint, that the user should install an app.

But that is nothing I see in that library here. It must be implemented by the individual authentication process.
However, to enable this, it would be good to catch that error.

[denniskniep]

@shahzaibj implemented your suggestions

[denniskniep]

Hi @shahzaibj,
can you propose someone who can be the second reviewer?

[denniskniep]

@rpdome any further feedback? Can we merge this?

[denniskniep]

@rpdome I kept up with recent changes in repo with rebase

[iamgusain]

@denniskniep how did you test this?
Can that be written as an automated test?

[iamgusain]

Approved with suggestion.

[denniskniep]

how did you test this? Can that be written as an automated test?

@iamgusain I didn´t wrote a unit-test so far for this case. If you want me to write a test for that catch block, I can look into that.

[denniskniep]

Hi,
I merged dev into that pr to resolve conflicts

@iamgusain @shahzaibj There are now two approvals, can we merge this?