Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shot limit on HUD #170

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

The-Noah
Copy link
Contributor

Add the number of shots left for the current flag on the HUD. Remove the messages saying the number of shots left.

The-Noah added 2 commits July 26, 2018 21:44
Add the number of shots left for the current flag on the HUD. Remove the messages saying the number of shots left.
Change the shot limit label location to be on top of the shot indicators instead of to the right of them. Also make them slightly transparent. Fix problem where not showing the currect number when observing.
@allejo
Copy link
Member

allejo commented Jul 27, 2018

Since this affects the client visually, please share screenshots of what your changes do. This way we get an idea of how it'll look and be able to give you feedback all without having to download your patch and test it ourselves.

@allejo allejo added this to the 2.6 Release milestone Jul 27, 2018
@The-Noah
Copy link
Contributor Author

bzfi0019

@JeffM2501
Copy link
Contributor

It needs some kind of label or icon next to the number showing that it's a limit, not just a random floating number.

When the player grabs a flag with a limited number of shots, the label will fade in for 1 second, show for 3, then fade out for 1 second.
@The-Noah
Copy link
Contributor Author

I added a 'shots left' label. You can see the commit description for details.

Here is a screen shot of it when it is completely shown.
bzfi0020

@allejo
Copy link
Member

allejo commented Jul 31, 2018

I'm personally hesitant of the location of this label. Thoughts on placement? I'd favor a place where other flag information is already stored, e.g.

  • Bottom of the mouse box, above where flag help messages would appear
  • Upper right next to the flag name

@The-Noah
Copy link
Contributor Author

Hmm. I could add a simple option to switch it's location between where you said, that way if the player doesn't like it in one spot he/she could move it to the other. What do you think?

@JeffM2501
Copy link
Contributor

BZFlag does not need more options.
Show us screenshots or mockups with both locations.
I prefer lower near the shot reloads, since that's already shot related.

But there may be more room near the flag

@allejo
Copy link
Member

allejo commented May 19, 2019

Since this PR has grown stale and it's something we're going to need to discuss further with some more mockups, I'm placing this one on hold.

@allejo allejo added the on hold label May 19, 2019
@TheGiraffe3
Copy link
Contributor

So what's the status on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants