Kick all replay viewers when an incompatible replay is loaded #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheGiraffe3
reviewed
Nov 28, 2024
src/bzfs/RecordReplay.cxx
Outdated
| * | ||
| * 4) implement a world reload feature on the client side, | ||
| * so that if the server sends a MsgGetWorld to the client | ||
| * when it isn't expecting one, it reaquires and regenerates |
There was a problem hiding this comment.
Suggested change
| * when it isn't expecting one, it reaquires and regenerates | |
| * when it isn't expecting one, it reacquires and regenerates |
TheGiraffe3
approved these changes
Nov 29, 2024
Rejoining was already required, since playing an incompatible replay without rejoining would usually crash the client.
blast007
force-pushed
the
improvement/incompatible-replay-kick
branch
from
f35b80e to
d6dc032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rejoining was already required, since playing an incompatible replay without rejoining would usually crash the client.
This resolves #348