Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LocationManager minUpdateIntervalMillis #1402

Merged
merged 2 commits into from
Jan 15, 2024
Merged

fix LocationManager minUpdateIntervalMillis #1402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a59e4
fix LocationManager `minUpdateIntervalMillis`
vanelizarov Dec 31, 2023
d216de4
bump version, update CHANGELOG
vanelizarov Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions geolocator_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 4.4.1

* Fixes a bug where `getPositionStream` caused an `java.lang.IllegalStateException: passive location requests must have an explicit minimum update interval` because `minUpdateIntervalMillis` property in location request was set to -1 by default

## 4.4.0

- Adds `color` to `ForegroundNotificationConfig` to set the color of the notification icon.
Expand Down
1 change: 1 addition & 0 deletions ...android/android/src/main/java/com/baseflow/geolocator/location/LocationManagerClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ public void startPositionUpdates(

final LocationRequestCompat locationRequest = new LocationRequestCompat.Builder(timeInterval)
.setMinUpdateDistanceMeters(distanceFilter)
.setMinUpdateIntervalMillis(timeInterval)
.setQuality(quality)
.build();

Expand Down
2 changes: 1 addition & 1 deletion geolocator_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: geolocator_android
description: Geolocation plugin for Flutter. This plugin provides the Android implementation for the geolocator.
repository: https://github.com/baseflow/flutter-geolocator/tree/main/geolocator_android
issue_tracker: https://github.com/baseflow/flutter-geolocator/issues?q=is%3Aissue+is%3Aopen
version: 4.4.0
version: 4.4.1

environment:
sdk: ">=2.15.0 <4.0.0"
Expand Down