Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Handle errors in request access #1458

Conversation

daniel-kane-everbridge-com
Copy link
Contributor

Fixes crash under Windows when RequestAccess is called while the Geolocation Service is disabled.

  • this is done by swallowing any error thrown from geolocator.RequestAccessAsync();

Dan Kane added 2 commits March 14, 2024 13:53
 - this can throw errors if the Geolocation Service is disabled in Windows.
Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this contribution.

@mvanbeusekom mvanbeusekom merged commit 3b58610 into Baseflow:main Mar 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants